[draft] excess image resize maintain aspect ratio #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| max_width = 512 | ||
| max_height = 512 | ||
| if width > max_width or height > max_height: | ||
| downsize_factor = max(width // max_width, height // max_height) |
There was a problem hiding this comment.
The new helper function resize_pil computes the downsize_factor using integer division (e.g. width // max_width), so for images only slightly above 512 (e.g. 600×700) the factor is 1 and no resizing occurs. Consider computing a floating‑point scale factor (e.g. scale = min(max_width/width, max_height/height)) and then resizing with new dimensions (int(width*scale), int(height*scale)). Also, specify a resampling filter like Image.LANCZOS for better quality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently images seem to get hard-adjusted to 512,512 if either width or height exceeds 512
we have a helper function to resize images while maintaining aspect ratio so this PR re-uses it
Important
Replace hard-coded image resize with
resize_pil()to maintain aspect ratio indataset.pyandembed.py.resize_pil()in_add_blobs()indataset.pyandimage()inembed.pyto maintain aspect ratio.resize_pil()fromembed.pytoutils.pyfor reuse.resize_pilimport todataset.pyandembed.py.This description was created by
for 9aeee9e. It will automatically update as commits are pushed.