Work around changes in Click 8.2.0 #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
Click 8.2.0 strictly separated stdout & stderr. The logs were in stderr, but were visible in stdout, too. Now, use the proper "output" for the mixed stream when the specific stream is irrelevant (almost always). Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Click 8.2.0 has been released 2 days ago: 2025-05-10. It has introduced a few changes that are irrelevant for Kopf, but broke the CI end2end tests:
Specifically:
Hence, switch from
.stdoutto.outputin the end2end tests. The expected logs go to stderr, but they were previously visible in.stdout, so I used whatever worked.This failed the mypy checks. The proper fix would be to remake
LogFormatParamTypeto inhert fromclick.Choice[loggers.LogFormat](the enum). But this requires the strict dependency forclick>=8.2.0for Kopf, since the type was not a generic in 8.1.x and before. However, Click 8.2.0 also drops the support for the yet-alive Python 3.9, which should be supported in Kopf till October 2025. So, I cannot make Kopf depend onclick>=8.2.0yet.Therefore, suppress the line for the time being. Get back to that line when Python 3.9 is dropped from Kopf.