8000 Refactor item codes by jordanbrauer · Pull Request #18 · nokka/d2s · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor item codes #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2021
Merged

Refactor item codes #18

merged 3 commits into from
Feb 12, 2021

Conversation

jordanbrauer
Copy link
@jordanbrauer jordanbrauer commented Dec 18, 2020 •
edited
Loading

Closes #17

  • make named constants for all item codes (e.g., uui is assigned to DuskShroud string)
    • Note that in the weaponDamageMap there is an unused/unknown two-handed sword code, 7sh – i am/was not sure what it is
  • replace all hard-coded item codes with their named constant
    • this includes socketables.go
  • export some types for consumer usage (e.g., func arguments types, modifying/merging/creating new, etc.)
    • magicAttribute -> MagicAttribute
    • weaponDamage -> WeaponDamage
    • magicalProperty -> MagicalProperty

@nokka nokka merged commit 0b32be8 into nokka:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nokka nokka nokka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make item codes available through constants (similar to class.go)
2 participants
@jordanbrauer @nokka
0