doc, http: add rejectNonStandardBodyWrites option, clear its behaviour
#53396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
lpinca
approved these changes
Jun 9, 2024
ShogunPanda
approved these changes
Jun 10, 2024
UlisesGascon
approved these changes
Jun 10, 2024
marco-ippolito
approved these changes
Jun 10, 2024
Commit Queue failed- Loading data for nodejs/node/pull/53396 ✔ Done loading data for nodejs/node/pull/53396 ----------------------------------- PR info ------------------------------------ Title doc, http: add `rejectNonStandardBodyWrites` option, clear its behaviour (#53396) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch jakecastelli:fix-53035 -> nodejs:main Labels http, doc, author ready Commits 2 - doc, http: add `rejectNonStandardBodyWrites` option, clear its behaviour - fixup! Committers 1 - jakecastelli <959672929@qq.com> PR-URL: https://github.com/nodejs/node/pull/53396 Fixes: https://github.com/nodejs/node/issues/53035 Reviewed-By: Luigi Pinca Reviewed-By: Paolo Insogna Reviewed-By: Ulises Gascón Reviewed-By: Marco Ippolito Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53396 Fixes: https://github.com/nodejs/node/issues/53035 Reviewed-By: Luigi Pinca Reviewed-By: Paolo Insogna Reviewed-By: Ulises Gascón Reviewed-By: Marco Ippolito Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 09 Jun 2024 15:57:36 GMT ✔ Approvals: 5 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53396#pullrequestreview-2106362720 ✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/53396#pullrequestreview-2107371369 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/53396#pullrequestreview-2107511309 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/53396#pullrequestreview-2107859286 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53396#pullrequestreview-2109979771 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 53396 From https://github.com/nodejs/node * branch refs/pull/53396/merge -> FETCH_HEAD ✔ Fetched commits as 94c81784422e..1112d9752552 -------------------------------------------------------------------------------- [main 401a614dcc] doc, http: add `rejectNonStandardBodyWrites` option, clear its behaviour Author: jakecastelli <959672929@qq.com> Date: Mon Jun 10 01:24:07 2024 +0930 1 file changed, 7 insertions(+), 2 deletions(-) [main b7db59c059] fixup! Author: jakecastelli <959672929@qq.com> Date: Mon Jun 10 01:31:30 2024 +0930 1 file changed, 1 insertion(+), 2 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/9468967820 |
|
Landed in 521c9c6 |
sophoniie
pushed a commit
to sophoniie/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53396 Fixes: nodejs#53035 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#53396 Fixes: nodejs#53035 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document
rejectNonStandardBodyWritesoption and its behaviour. Make the documentation clear that rejection only happens whenrejectNonStandardBodyWritesis set to true.Fixes: #53035
Refs: #47732 (comment), #47480