[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: print v8::OOMDetails::detail when it's available #53360

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

joyeecheung
Copy link
Member

This provides a bit more information when V8 runs out of memory.

This provides a bit more information when V8 runs out of memory.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 6, 2024
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 6, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 6, 2024
@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member
targos commented Jun 6, 2024

Could we add a test or the presence of the additional info is unreliable?

@legendecas
Copy link
Member

Most OOMDetails don't have a detail available. At the moment I can only find details present in wasm: https://source.chromium.org/chromium/chromium/src/+/main:v8/src/wasm/wasm-code-manager.cc;l=706?q=FatalProcessOutOfMemory

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 12, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 12, 2024
@nodejs-github-bot
Copy link
Collaborator

@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2024
@nodejs-github-bot
Copy link
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/53360
✔  Done loading data for nodejs/node/pull/53360
----------------------------------- PR info ------------------------------------
Title      src: print v8::OOMDetails::detail when it's available (#53360)
Author     Joyee Cheung  (@joyeecheung)
Branch     joyeecheung:oom-details -> nodejs:main
Labels     c++, needs-ci
Commits    1
 - src: print v8::OOMDetails::detail when it's available
Committers 1
 - Joyee Cheung 
PR-URL: https://github.com/nodejs/node/pull/53360
Reviewed-By: Chengzhong Wu 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53360
Reviewed-By: Chengzhong Wu 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 06 Jun 2024 09:07:02 GMT
   ✔  Approvals: 1
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/53360#pullrequestreview-2102221857
   ✘  This PR needs to wait 18 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-06-12T12:31:22Z: https://ci.nodejs.org/job/node-test-pull-request/59735/
- Querying data for job/node-test-pull-request/59735/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/9484561039

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jun 12, 2024
@debadree25 debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2024
@nodejs-github-bot nodejs-github-bot merged commit 5a19a9b into nodejs:main Jun 12, 2024
75 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5a19a9b

targos pushed a commit that referenced this pull request Jun 20, 2024
This provides a bit more information when V8 runs out of memory.

PR-URL: #53360
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
This provides a bit more information when V8 runs out of memory.

PR-URL: nodejs#53360
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
This provides a bit more information when V8 runs out of memory.

PR-URL: nodejs#53360
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
This provides a bit more information when V8 runs out of memory.

PR-URL: #53360
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
This provides a bit more information when V8 runs out of memory.

PR-URL: #53360
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants