8000 add webSocket example by mertcanaltin · Pull Request #2626 · nodejs/undici · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add webSocket example #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 26, 2024
Merged

add webSocket example #2626

merged 5 commits into from
Jan 26, 2024

Conversation

mertcanaltin
Copy link
Member

I have attached a websocket example

@codecov-commenter
Copy link
codecov-commenter commented Jan 18, 2024 •
edited
Loading

Codecov Report

Attention: 188 lines in your changes are missing coverage. Please review.

Comparison is base (e39a632) 85.54% compared to head (11299b7) 85.44%.
Report is 233 commits behind head on main.

Files Patch % Lines
lib/fetch/util.js 38.46% 48 Missing ⚠️
lib/fetch/index.js 64.80% 44 Missing ⚠️
lib/cache/cache.js 2.94% 33 Missing ⚠️
lib/handler/RetryHandler.js 74.35% 30 Missing ⚠️
lib/core/diagnostics.js 84.74% 9 Missing ⚠️
lib/api/readable.js 88.88% 5 Missing ⚠️
lib/fetch/headers.js 90.19% 5 Missing ⚠️
lib/client.js 95.23% 3 Missing ⚠️
lib/compat/dispatcher-weakref.js 57.14% 3 Missing ⚠️
lib/core/util.js 95.65% 2 Missing ⚠️
... and 5 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2626      +/-   ##
==========================================
- Coverage   85.54%   85.44%   -0.11%     
==========================================
  Files          76       84       +8     
  Lines        6858     7544     +686     
==========================================
+ Hits         5867     6446     +579     
- Misses        991     1098     +107

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mertcanaltin
Copy link
Member Author

@ronag, @mcollina Greetings, I wonder if I am proceeding correctly here, I would be very happy if you could take a look 🚀

@metcoder95 < 8000 /div>
Copy link
Member

Are we solving any specific issue in here?

@mertcanaltin
Copy link
Member Author

Are we solving any specific issue in here?

no, it was just a todo I saw and I wanted to fill in the gaps @metcoder95

metcoder95
metcoder95 reviewed Jan 24, 2024
View reviewed changes
Copy link
Member
@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example LGTM, I would just put it in maybe another file within /proxy directory just to not overlap the with the current proxy example

@mertcanaltin
Copy link
Member Author

The example LGTM, I would just put it in maybe another file within /proxy directory just to not overlap the with the current proxy example

now I am implementing it immediately, I will try to implement it in a separate file instead of writing it inside.

@mertcanaltin
Copy link
Member Author

I did an update, I hope I went the right way @metcoder95 🚀

metcoder95
metcoder95 reviewed Jan 25, 2024
View reviewed changes