8000 fix(debug): remove extra forward slash in logs by aidant · Pull Request #4236 · nodejs/undici · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(debug): remove extra forward slash in logs #4236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Conversation

aidant
Copy link
Contributor
@aidant aidant commented May 23, 2025

This relates to...

Rationale

When fixing an issue in a unrelated third-party package that was incorrectly adding an extra forward slash. The node debug logs still contained an extra forward slash which lead me to believe the issue had not been patched in the unrelated third-party package.

Changes

Features

Bug Fixes

When enabling the fetch debug logs, the request contains two forward slashes.

Breaking Changes and Deprecations

Status

@aidant aidant changed the title fix(debug): remove extra fordward slash in logs fix(debug): remove extra forward slash in logs May 23, 2025
Copy link
Member
@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

Copy link
Contributor
@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

but why are the tests failing?

@artur-ma
Copy link
Contributor
artur-ma commented May 25, 2025

LGTM

but why are the tests failing?

Fails also on this PR
#4228

@Uzlopak Uzlopak merged commit c3c312c into nodejs:main May 30, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0