8000 chore: remove uuid dependency by isaac0yen · Pull Request #421 · node-cron/node-cron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: remove uuid dependency #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

isaac0yen
Copy link
@isaac0yen isaac0yen commented May 24, 2024

The uuid dependency was removed because it was no longer needed in the project.
It was previously used for generating unique identifiers, but that functionality
has been replaced with a different approach or is no longer required.

Removing this dependency reduces the overall package size and eliminates
potential security vulnerabilities associated with outdated or unmaintained
dependencies.

Hello @PowerKiKi @waldyrious

I have created this pull request pull #421.

Could you please take a look and provide feedback? Your guidance would be greatly appreciated!

Thank you!

Copy link
Contributor
@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not good. You are replacing a maintained package with some unmaintained custom code that already fails to be secure by using Math.random(). Use native things instead.

You also mix formatting changes with logic changes for no reasons.

@isaac0yen
Copy link
Author

This is not good. You are replacing a maintained package with some unmaintained custom code that already fails to be secure by using Math.random(). Use native things instead.

You also mix formatting changes with logic changes for no reasons.

Thank you very much for your time.

I have replaced the previous UUID generation function with a version that uses
Node.js' built-in crypto module to generate cryptographically secure
random bytes and convert them to a UUID string format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0