-
Notifications
You must be signed in to change notification settings - Fork 260
chore: remove uuid dependency #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not good. You are replacing a maintained package with some unmaintained custom code that already fails to be secure by using Math.random()
. Use native things instead.
You also mix formatting changes with logic changes for no reasons.
Thank you very much for your time. I have replaced the previous UUID generation function with a version that uses |
… the inbuilt crypto module
The uuid dependency was removed because it was no longer needed in the project.
It was previously used for generating unique identifiers, but that functionality
has been replaced with a different approach or is no longer required.
Removing this dependency reduces the overall package size and eliminates
potential security vulnerabilities associated with outdated or unmaintained
dependencies.
Hello @PowerKiKi @waldyrious
I have created this pull request pull #421.
Could you please take a look and provide feedback? Your guidance would be greatly appreciated!
Thank you!