fix: filters / conditions #2535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranav C <pranavxc@gmail.com>
mertmit
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
| Filter Type | Many to many | Has many | Belongs to | Lookup |
|---|---|---|---|---|
| is null | ✅ | ✅ | ✔️ | ✅ |
| is not null | ✅ | ✅ | ✔️ | ✅ |
| is empty | ✔️ | ✔️ | ✅ | ✅ |
| is not empty | ✔️ | ✔️ | ✅ | ✅ |
✔️ -> tested & working
✅ -> restricted from UI
The only thing is if someone has 'is not null filter' on mm or hm columns which seem to work, it becomes an empty filter which still applied but user can delete or change it so this should be fine
o1lab
pushed a commit
that referenced
this pull request
Mar 14, 2024
o1lab
pushed a commit
that referenced
this pull request
Mar 15, 2024
dstala
added a commit
that referenced
this pull request
Mar 15, 2024
* fix(nc-gui): select type fields default value update issue * chore(nc-gui): lint * fix(nc-gui): pr review changes #2535 * fix: remove null assertion --------- Co-authored-by: Raju Udava <86527202+dstala@users.noreply.github.com>
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
ref: #2516
is null&is not nullis empty&is not emptyis null,is not null,is empty&is not emptyChange type
Test/ Verification
Sheet 1: hm
Sheet 2: bt
Sheet 3 : mm
Sheet 4: mm
Display Flow