fix: ensure decimal columns are typed as number in OpenAPI schema #11719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Decimal columns in NocoDB are being labeled as string type in the OpenAPI specification (swagger.json), but the actual API returns them as floating point numbers. This causes issues with strongly typed languages like Rust when using auto-generated clients.
Solution
This PR explicitly sets the type of decimal columns to 'number' in the OpenAPI schema generation for both the swagger and swaggerV2 implementations. This ensures that the schema correctly reflects the actual data type returned by the API.
Changes
UITypes.Decimalin both swagger and swaggerV2 implementations to ensure they are always typed as 'number' in the OpenAPI schema.Fixes #11718
💻 View my work • About Codegen