8000 fix: User group-by bug by pranavxc · Pull Request #11400 · nocodb/nocodb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: User group-by bug #11400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2025
Merged

fix: User group-by bug #11400

merged 1 commit into from
May 17, 2025

Conversation

pranavxc
Copy link
Member

Change Summary

Provide summary of changes with issue number if any.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 16, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

The changes add an explicit alias nc_subquery to SQL subqueries generated in both PostgreSQL and SQLite3 aggregation functions. This modification updates the SQL syntax in the respective query-construction functions to ensure the subqueries are named, without altering any logic, control flow, or exported declarations.

Changes

File(s) Change Summary
packages/nocodb/src/db/aggregations/pg.ts Added alias nc_subquery to the subquery in the SQL generated by replaceDelimitedWithKeyValuePg.
packages/nocodb/src/db/aggregations/sqlite3.ts Added alias nc_subquery to the subquery in the SQL generated by replaceDelimitedWithKeyValueSqlite3.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant AggregationFunction (pg/sqlite3)
    participant SQL Engine

    Caller->>AggregationFunction (pg/sqlite3): Call replaceDelimitedWithKeyValue*
    AggregationFunction (pg/sqlite3)->>AggregationFunction (pg/sqlite3): Construct SQL with subquery alias nc_subquery
    AggregationFunction (pg/sqlite3)->>SQL Engine: Execute SQL with aliased subquery
    SQL Engine-->>AggregationFunction (pg/sqlite3): Return results
    AggregationFunction (pg/sqlite3)-->>Caller: Return results
Loading
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 9f58aae and 49b1247.

📒 Files selected for processing (2)
  • packages/nocodb/src/db/aggregations/pg.ts (1 hunks)
  • packages/nocodb/src/db/aggregations/sqlite3.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: release-docker / buildx
  • GitHub Check: pre-build-for-playwright / playwright
  • GitHub Check: unit-tests-pg
  • GitHub Check: unit-tests
🔇 Additional comments (2)
packages/nocodb/src/db/aggregations/pg.ts (1)

447-447: SQL Subquery Alias Added for Valid Syntax

By aliasing the derived table as nc_subquery, you satisfy PostgreSQL’s requirement that every subquery in the FROM clause must have an alias. This aligns with SQL standards and prevents runtime errors when executing the generated query.

packages/nocodb/src/db/aggregations/sqlite3.ts (1)

460-460: SQLite3 Subquery Alias Added for Valid Syntax

The addition of the nc_subquery alias here mirrors the change in the PostgreSQL implementation, ensuring that SQLite also recognizes the subquery in the FROM clause. This consistency across dialects prevents “missing alias” errors.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Commit Unit Tests in branch nc-fix/5535-group-by-user
  • Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@o1lab o1lab force-pushed the nc-fix/5535-group-by-user branch from 75c50ff to 49b1247 Compare May 16, 2025 21:17
@pranavxc pranavxc merged commit 08ce892 into develop May 17, 2025
35 of 39 checks passed
@pranavxc pranavxc deleted the nc-fix/5535-group-by-user branch May 17, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendy3002 fendy3002 fendy3002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pranavxc @fendy3002
0