8000 fix:keyboard field interactions broken after filter is modified by DarkPhoenix2704 · Pull Request #11453 · nocodb/nocodb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix:keyboard field interactions broken after filter is modified #11453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

fix:keyboard field interactions broken after filter is modified #11453

merged 1 commit into from
May 22, 2025

Conversation

DarkPhoenix2704
Copy link
Member

Change Summary

Closes https://github.com/nocodb/nocohub/issues/5574

Change type

  • fix: (bug fix for the user, not a fix to a build script)

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 22, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

A conditional rendering logic was updated in the ColumnFilter.vue component. The filter input component is now displayed only if a specific combination of showFilterInput, isViewFilter, and isOpen conditions are met, introducing more granular control over its visibility.

Changes

File(s) Change Summary
packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue Updated the rendering condition for the filter input component to require both showFilterInput(filter) and, when isViewFilter is true, also isOpen to be true.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ColumnFilter.vue

    User->>ColumnFilter.vue: Triggers filter rendering
    ColumnFilter.vue->>ColumnFilter.vue: Evaluate showFilterInput(filter)
    alt showFilterInput(filter) is true
        alt isViewFilter is true and isOpen is true
            ColumnFilter.vue->>ColumnFilter.vue: Render Filter Input
        else isViewFilter is false
            ColumnFilter.vue->>ColumnFilter.vue: Render Filter Input
        else
            ColumnFilter.vue->>ColumnFilter.vue: Do not render Filter Input
        end
    else
        ColumnFilter.vue->>ColumnFilter.vue: Do not render Filter Input
    end
Loading

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82ca12e and c2862ec.

📒 Files selected for processing (1)
  • packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings 
Learnt from: DarkPhoenix2704
PR: nocodb/nocodb#8781
File: packages/nc-gui/components/smartsheet/grid/GroupBy.vue:225-232
Timestamp: 2024-06-18T13:58:19.464Z
Learning: DarkPhoenix2704 prefers to keep code implementations that prioritize readability, even if an alternative might be more concise.
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: release-docker / buildx
  • GitHub Check: pre-build-for-playwright / playwright
  • GitHub Check: unit-tests
  • GitHub Check: unit-tests-pg
🔇 Additional comments (1)
packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (1)

889-889: Good fix for keyboard field interaction issue!

This change ensures the SmartsheetToolbarFilterInput component is only rendered when both necessary conditions are met: when the filter needs an input value (showFilterInput(filter)) and when the filter view is open in case of view filters (isViewFilter ? isOpen : true). This prevents keyboard interactions from being intercepted by invisible or inactive filter inputs.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dstala dstala merged commit f4030a3 into develop May 22, 2025
21 of 22 checks passed
@dstala dstala deleted the nc-arrow-not-working branch May 22, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstala dstala dstala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkPhoenix2704 @dstala
0