8000 feat: show no access message if license key limited with 1 workspace by dstala · Pull Request #11366 · nocodb/nocodb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: show no access message if license key limited with 1 workspace #11366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

feat: show no access message if license key limited with 1 workspace #11366

merged 1 commit into from
May 14, 2025

Conversation

dstala
Copy link
Member
@dstala dstala commented May 14, 2025

Change Summary

Provide summary of changes with issue number if any.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@mertmit mertmit merged commit 7d03013 into develop May 14, 2025
8 of 9 checks passed
@mertmit mertmit deleted the nc-fix/4712-on-prem-sso branch May 14, 2025 06:57
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 14, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes introduce a new SSO error type, MAX_WORKSPACE_LIMIT_REACHED, across the SDK and backend, with corresponding error handling logic and messages. A new composable and Vue component are added for centralized SSO error management and user feedback. Middleware is updated to handle and display this specific error during authentication.

Changes

Files/Paths Change Summary
packages/nc-gui/components/auth/NoAccess.vue Added a new Vue component for displaying SSO access errors, with localization and retry support.
packages/nc-gui/composables/useSsoError.ts Introduced a composable for centralized SSO error state management and exposure of error handling functions.
packages/nc-gui/middleware/03.auth.global.ts Updated middleware to detect MAX_WORKSPACE_LIMIT_REACHED errors, set global error state, and redirect to /sso.
packages/nocodb-sdk/src/lib/globals.ts Added MAX_WORKSPACE_LIMIT_REACHED to the NcErrorType enum.
packages/nocodb/src/helpers/catchError.ts Added error helper and static method for MAX_WORKSPACE_LIMIT_REACHED with message and status code 403.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Frontend (Middleware)
    participant Backend (API)
    participant SSO Error Store
    participant NoAccess.vue

    User->>Frontend (Middleware): Attempt SSO authentication
    Frontend (Middleware)->>Backend (API): Exchange short token
    Backend (API)-->>Frontend (Middleware): Responds with MAX_WORKSPACE_LIMIT_REACHED error
    Frontend (Middleware)->>SSO Error Store: setError(error details)
    Frontend (Middleware)->>User: Redirect to /sso
    User->>NoAccess.vue: View error page
    NoAccess.vue->>SSO Error Store: Access error state
    User->>NoAccess.vue: Click "Try Again"
    NoAccess.vue->>SSO Error Store: clearError()
Loading

Suggested reviewers

  • mertmit

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec2a73d and 2238fc6.

⛔ Files ignored due to path filters (1)
  • packages/nc-gui/lang/en.json is excluded by !**/*.json
📒 Files selected for processing (5)
  • packages/nc-gui/components/auth/NoAccess.vue (1 hunks)
  • packages/nc-gui/composables/useSsoError.ts (1 hunks)
  • packages/nc-gui/middleware/03.auth.global.ts (3 hunks)
  • packages/nocodb-sdk/src/lib/globals.ts (1 hunks)
  • packages/nocodb/src/helpers/catchError.ts (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new revie 894E w comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertmit mertmit mertmit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstala @mertmit @pranavxc
0