8000 test: skip expand modes in OSS by dstala · Pull Request #11360 · nocodb/nocodb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test: skip expand modes in OSS #11360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2025
Merged

test: skip expand modes in OSS #11360

merged 3 commits into from
May 14, 2025

Conversation

dstala
Copy link
Member
@dstala dstala commented May 13, 2025

Change Summary

Provide summary of changes with issue number if any.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@dstala
test: skip expand modes in OSS
7ae37c1 
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 13, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

The test suite for "Expanded form files mode" was updated to skip all tests when the environment is not Enterprise Edition by checking the result of the isEE function at the beginning of the test block. Additionally, a 100ms wait was added after waiting for a dropdown element to become visible in the UserOptionCellPageObject class. No other test logic or structure was changed.

Changes

File(s) Change Summary
tests/playwright/tests/db/features/expandedFormModeFiles.spec.ts Added a conditional check using isEE() to skip all tests if not running in Enterprise Edition.
tests/playwright/pages/Dashboard/common/Cell/UserOptionCell.ts Added a 100ms wait after waiting for the dropdown to become visible before selecting an option.

Sequence Diagram(s)

sequenceDiagram
    participant TestSuite as ExpandedFormModeFiles.spec.ts
    participant Env as Environment (isEE)
    TestSuite->>Env: isEE()
    alt isEE() returns false
        TestSuite->>TestSuite: test.skip() (skip all tests)
    else isEE() returns true
        TestSuite->>TestSuite: Run tests as normal
    end
Loading

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

dstala added 2 commits May 13, 2025 22:18
@dstala
fix: remove .only override
d1d974c 
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
@dstala
fix: user field selection, add delay
36fb239 
Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
coderabbitai[bot]
coderabbitai bot reviewed May 13, 2025
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
tests/playwright/pages/Dashboard/common/Cell/UserOptionCell.ts (1)

42-43: Fix mismatch between comment and implementation.

The comment states "add 500ms wait" but the actual implementation uses only 100ms. This discrepancy could confuse developers reading the code in the future.

Update the comment to match the actual timeout value:

- // add 500ms wait to ensure dropdown is open
+ // add 100ms wait to ensure dropdown is open
  await this.rootPage.waitForTimeout(100);

Or, if 500ms was the intended value:

  // add 500ms wait to ensure dropdown is open
- await this.rootPage.waitForTimeout(100);
+ await this.rootPage.waitForTimeout(500);
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d1d974c and 36fb239.

📒 Files selected for processing (1)
  • tests/playwright/pages/Dashboard/common/Cell/UserOptionCell.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: pre-build-for-playwright / playwright
  • GitHub Check: unit-tests-pg
  • GitHub Check: unit-tests

@rameshmane7218 rameshmane7218 merged commit a66901d into develop May 14, 2025
12 of 17 checks passed
@rameshmane7218 rameshmane7218 deleted the test/pw-fix-250513 branch May 14, 2025 07:55
Sign up for free 6544 to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@rameshmane7218 rameshmane7218 rameshmane7218 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstala @rameshmane7218
0