8000 fix: improve import button visibility during loading state by codegen-sh[bot] · Pull Request #11285 · nocodb/nocodb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: improve import button visibility during loading state #11285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2025
Merged

fix: improve import button visibility during loading state #11285

merged 3 commits into from
May 5, 2025

Conversation

codegen-sh[bot]
Copy link
Contributor
@codegen-sh codegen-sh bot commented May 5, 2025

Changes

This PR improves the visibility of the "Import" button in the CSV/Excel import modal during the loading state.

Current behavior

  • When importing, the button turns grey and shows "Importing..." text with a loader
  • The text is barely visible on the grey background

New behavior

  • The button maintains its primary blue color during loading
  • Only shows a centered loader without any text, making it cleaner and more visible

Implementation details

  1. Modified the getBtnText function to return an empty string when in loading state
  2. Added CSS to ensure the button maintains its primary blue color during loading

This change applies to both the pre-import button on the initial screen and the import button in the template editor modal.

Fixes the issue where the "Importing..." text was barely visible on the button during the import process.

💻 View my work • About Codegen

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 5, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dstala
Copy link
Member
dstala commented May 5, 2025 •
edited by codegen-sh bot
Loading

@codegen-sh

  • keep the width of the button same as "Import" button when displaying only loader
  • increase weight of the loader - currently it appears tad thin

Got it! I'll adjust the loader width and weight to match the Import button 🛠️

💻 View my work

@codegen-sh codegen-sh
Copy link
Contributor Author
codegen-sh bot commented May 5, 2025

I've made the requested changes to improve the import button visibility during loading state:

  1. Fixed button width: Added min-width: 80px to ensure the button maintains the same width when showing only the loader, preventing layout shifts.

  2. Increased loader weight: Added CSS to increase the stroke width of the loader from the default to 3px, making it more visible and prominent.

These changes have been pushed to your PR branch. The button now maintains its blue color during loading (from your original PR) while also keeping a consistent width and showing a more prominent loader.

You can see the changes in this commit: 2a8d9b14fa

Let me know if you'd like any further adjustments to the styling!

💻 View my work • React 👍 or 👎

@pranavxc pranavxc marked this pull request as ready for review May 5, 2025 07:42
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 5, 2025 •
edited
Loading

Uffizzi Ephemeral Environment Deploying

☁️ https://app.uffizzi.com/github.com/nocodb/nocodb/pull/11285

⚙️ Updating now by workflow run 14832453356.

What is Uffizzi? Learn more!

@codegen-sh codegen-sh
Copy link
Contributor Author
codegen-sh bot commented May 5, 2025

Hey! 👋 I see one of the checks failed. I am on it! 🫡

💻 View my work

@codegen-sh codegen-sh
Copy link
Contributor Author
codegen-sh bot commented May 5, 2025

✅ Fixed failing check in this commit. The issue was trailing whitespace in the CSS that needed to be removed.

💻 View my work • React 👍 or 👎

@dstala dstala merged commit 477ede4 into develop May 5, 2025
21 of 22 checks passed
@dstala dstala deleted the codegen-bot/9b8ceed6 branch May 5, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavxc pranavxc pranavxc approved these changes

Assignees
No one assigned
Labels
< 4749 div class="js-issue-labels d-flex flex-wrap"> None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstala @pranavxc
0