8000 fix: remove dashboard path in reset password and token verify url by pranavxc · Pull Request #11269 · nocodb/nocodb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: remove dashboard path in reset password and token verify url #11269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2025
Merged

fix: remove dashboard path in reset password and token verify url #11269

merged 2 commits into from
May 2, 2025

Conversation

pranavxc
Copy link
Member
@pranavxc pranavxc commented May 2, 2025 •
edited by DarkPhoenix2704
Loading

Change Summary

Closes #11231 (comment)

Change type

  • fix: (bug fix for the user, not a fix to a build script)

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 2, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

The update adjusts the logic in the buildUrl method within the MailService class. The main change is the repositioning of where the dashboardPath is appended during URL construction. Now, dashboardPath is appended only after checking for resetPassword and verificationToken parameters, resulting in these specific URLs being constructed without the dashboardPath component. The rest of the URL building logic and method signatures are unchanged.

Changes

File(s) Change Summary
packages/nocodb/src/services/mail/mail.service.ts Modified the buildUrl method to change when and how dashboardPath is appended during URL creation.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant MailService

    Caller->>MailService: buildUrl(req, params)
    alt resetPassword or verificationToken present
        MailService-->>Caller: Construct URL without dashboardPath
    else
        MailService-->>Caller: Construct URL with dashboardPath
    end
Loading
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ca9a3d and 5227cf9.

📒 Files selected for processing (1)
  • packages/nocodb/src/services/mail/mail.service.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/nocodb/src/services/mail/mail.service.ts
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: release-docker / buildx
  • GitHub Check: pre-build-for-playwright / playwright
  • GitHub Check: unit-tests
  • GitHub Check: unit-tests-pg
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@o1lab o1lab force-pushed the nc-fix-reset-password branch from 6ca9a3d to 5227cf9 Compare May 2, 2025 11:42
@DarkPhoenix2704 DarkPhoenix2704 merged commit 6bfc99d into develop May 2, 2025
18 of 21 checks passed
@DarkPhoenix2704 DarkPhoenix2704 deleted the nc-fix-reset-password branch May 2, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkPhoenix2704 DarkPhoenix2704 DarkPhoenix2704 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Forgot password always "Password reset successful!"
2 participants
@pranavxc @DarkPhoenix2704
0