Nc style(nc-gui): Update font from Manrope to Inter #11259
Conversation
|
Warning Rate limit exceeded@o1lab has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 18 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (20)
📒 Files selected for processing (46)
📝 Walkthrough## Walkthrough
This change set replaces the primary UI font from "Manrope" to "Inter" across all canvas rendering contexts and related UI components in the codebase. It introduces new font asset CSS files for "Inter" and updates the Nuxt configuration to use a new font stylesheet. The WindiCSS configuration is expanded with a comprehensive set of named font sizes and styles. All canvas cell renderers, utility functions, and composables that previously referenced "Manrope" now use "Inter" for text rendering, ensuring consistency. Additional font-face declarations for "Manrope", "Material Symbols", and "DM Mono" are included for broader font support.
## Changes
| File(s) | Change Summary |
|-------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `.../assets/style/fonts.css` | Added import for Inter font CSS and fixed missing semicolon in Manrope font-face rule. |
| `.../assets/style/Inter-new/inter.css` | New file: Adds comprehensive `@font-face` rules for "Inter" (weights 100–950, normal/italic) and `@font-feature-values` for advanced typographic options; includes global styles for font-feature-settings and numeric tabular alignment on form elements. |
| `.../assets/style/fonts-new.css` | New file: Adds font-face declarations for Manrope (variable), Material Symbols, and DM Mono; includes related CSS classes for font handling and icon hiding when fonts are not loaded. |
| `.../nuxt.config.ts` | Stylesheet link referencing `/shared/style/fonts.css` commented out; conditional CSS inclusion of `fonts.css` commented out and replaced with unconditional inclusion of `fonts.css` with TODO comments about removing old font files after testing. |
| `.../windi.config.ts` | Expanded `fontSize` theme: replaced simple entries with a detailed set of named sizes, each with font size, line height, weight, and letter spacing. Updated fontWeight scale with increased numeric values and added numeric keys. Added `inter` and `default` fontFamily entries with `['Inter', 'Manrope', 'sans-serif']`. |
| `.../canvas/utils/canvas.ts` | Updated all default font family strings from "Manrope" to "Inter" in text rendering utilities; changed default parameter values and explicit font assignments in functions like `renderSingleLineText`, `renderMultiLineText`, `renderMarkdown`, `renderTagLabel`, `renderMarkdownBlocks`, and `renderBarcode`. |
| `.../canvas/composables/useCanvasRender.ts` | Replaced all font family references from "Manrope" to "Inter" in canvas rendering contexts for headers, footers, group headers, tags, and other UI elements. |
| `.../canvas/index.vue` | Changed font family from "Manrope" to "Inter" for comment count labels and header tooltip rendering in canvas drawing contexts. Added scoped CSS rules enforcing minimum input height on certain cell elements excluding date/time cells. |
| `.../canvas/loaders/ImageLoader.ts` | Changed error rendering font from "Manrope" to "Inter" in `ImageWindowLoader`. |
| `.../canvas/cells/AILongText.ts`<br>`.../canvas/cells/Attachment.ts`<br>`.../canvas/cells/Button.ts`<br>`.../canvas/cells/Currency.ts`<br>`.../canvas/cells/Date.ts`<br>`.../canvas/cells/DateTime.ts`<br>`.../canvas/cells/Decimal.ts`<br>`.../canvas/cells/Duration.ts`<br>`.../canvas/cells/Email.ts`<br>`.../canvas/cells/Formula.ts`<br>`.../canvas/cells/GenericReadonlyRenderer.ts`<br>`.../canvas/cells/GeoData.ts`<br>`.../canvas/cells/Json.ts`<br>`.../canvas/cells/LTAR/HasMany.ts`<br>`.../canvas/cells/LTAR/ManyToMany.ts`<br>`.../canvas/cells/Links.ts`<br>`.../canvas/cells/LongText.ts`<br>`.../canvas/cells/Lookup.ts`<br>`.../canvas/cells/MultiSelect.ts`<br>`.../canvas/cells/Null.ts`<br>`.../canvas/cells/Number.ts`<br>`.../canvas/cells/Percent.ts`<br>`.../canvas/cells/PhoneNumber.ts`<br>`.../canvas/cells/Plain.ts`<br>`.../canvas/cells/QRCode.ts`<br>`.../canvas/cells/Rating.ts`<br>`.../canvas/cells/SingleLineText.ts`<br>`.../canvas/cells/SingleSelect.ts`<br>`.../canvas/cells/Time.ts`<br>`.../canvas/cells/Url.ts`<br>`.../canvas/cells/User.ts`<br>`.../canvas/cells/Year.ts`<br>`.../canvas/cells/index.ts` | Updated all canvas cell renderers to use "Inter" instead of "Manrope" for text rendering; updated font family in all relevant rendering, measurement, and interaction contexts. No logic or control flow changes. |
| `.../components/smartsheet/FormulaWrapperCell.vue` | Changed font used for offscreen canvas text width measurement from "Manrope" to "Inter". |
| `.../components/smartsheet/column/FormulaInputHelper.vue` | Changed CSS font-family for `.formula-placeholder` class from "Manrope" to "Inter". |
| `.../assets/css/global.css` | Updated `html` font-family to prioritize "Inter" over "Manrope" with extended fallback fonts. Changed RTL font-family from "Manrope" to "Inter". |
| `.../nocodb/src/services/mail/templates/components/RootWrapper.tsx` | Added `inter` fontFamily key to Tailwind theme configuration with value `['Inter', 'Manrope', 'sans-serif']`. |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant User
participant NuxtApp
participant CanvasRenderer
participant FontStylesheet
User->>NuxtApp: Loads application
NuxtApp->>FontStylesheet: Loads fonts-new.css (includes Inter, Manrope, Material Symbols, DM Mono)
NuxtApp->>CanvasRenderer: Initializes canvas rendering
CanvasRenderer->>FontStylesheet: Uses "Inter" for all text rendering
CanvasRenderer-->>User: Renders UI with Inter fontPossibly related PRs
Suggested reviewers
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (37)
packages/nc-gui/assets/style/Inter-4.1/inter.css (1)
129-176: Review CSS Fonts Module Level 4 usage
The@font-feature-valuesrule with nested@character-variantand@stylesetentries is part of CSS Fonts Module Level 4. Ensure your build pipeline (e.g. PostCSS) and target browsers support this at‐rule. You may need to add a linter exception or vendor plugin to prevent “unknown property” errors in tools like Biome.🧰 Tools
🪛 Biome (1.9.4)
[error] 131-131: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 132-132: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 133-133: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 134-134: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 135-135: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 136-136: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 137-137: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 138-138: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 139-139: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 140-140: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 141-141: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 142-142: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 143-143: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 144-144: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 145-145: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 146-146: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 147-147: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 148-148: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 149-149: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 150-150: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 151-151: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 152-152: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 153-153: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 154-154: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 155-155: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 156-156: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 159-159: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 160-160: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 161-161: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 162-162: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 163-163: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 164-164: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 165-165: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 166-166: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 167-167: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 168-168: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 169-169: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 170-170: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 171-171: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 172-172: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 173-173: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 174-174: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts (1)
18-18: Inter font applied correctly
ThefontFamily: '500 13px Inter'update aligns with the new typography.Consider extracting a shared constant or helper for canvas font strings to reduce duplication across renderers.
packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts (1)
260-260: Add a fallback generic font
ctx.font = '500 13px Inter'is correct, but appending a generic family (e.g.'500 13px Inter, sans-serif') ensures graceful degradation if the web font fails to load.packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts (1)
6-6: Main text font update is correct
Applying ``ctx.font = `${pv ? 600 : 500} 13px Inter``` preserves dynamic weight and switches to Inter.Optionally, centralize font‐string logic into a helper to keep renderers DRY.
packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts (1)
26-26: Dynamic Inter font with weight preserved
The change to ``fontFamily:${pv ? 600 : 500} 13px Inter``` correctly applies Inter while respectingpv`.For maintainability, consider extracting this template into a shared constant or function.
packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts (1)
218-218: Consider specifying a fallback generic font for robustness.Currently you set:
ctx.font = '500 13px Inter'which matches the CSS font syntax, but it’s good practice to include a fallback, e.g.:
- ctx.font = '500 13px Inter' + ctx.font = '500 13px Inter, sans-serif'This ensures legibility if Inter fails to load.
packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts (1)
25-25: Use a fallback font in the canvas text spec.The
fontFamilysetting here:fontFamily: `${pv ? 600 : 500} 13px Inter`,works, but adding a generic fallback is recommended:
- fontFamily: `${pv ? 600 : 500} 13px Inter`, + fontFamily: `${pv ? 600 : 500} 13px Inter, sans-serif`,This guards against font load failures.
packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts (1)
46-46: Include a fallback font in the fontFamily definition.To improve resilience:
- fontFamily: `${pv ? 600 : 500} 13px Inter`, + fontFamily: `${pv ? 600 : 500} 13px Inter, sans-serif`,Without a fallback, users may see an unintended default font if Inter doesn’t load.
packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts (1)
75-75: Add a generic fallback to the Inter font.Replace:
fontFamily: `${pv ? 600 : 500} 13px Inter`,with:
- fontFamily: `${pv ? 600 : 500} 13px Inter`, + fontFamily: `${pv ? 600 : 500} 13px Inter, sans-serif`,to ensure consistent rendering if Inter isn’t available.
packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts (1)
24-24: Add a fallback to enhance font loading robustness.Consider changing:
fontFamily: `${pv ? 600 : 500} 13px Inter`,to:
- fontFamily: `${pv ? 600 : 500} 13px Inter`, + fontFamily: `${pv ? 600 : 500} 13px Inter, sans-serif`,so the canvas text falls back gracefully.
packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts (1)
22-22: Consider centralizing canvas font string and adding fallbacks
The font is hard-coded as${pv ? 600 : 500} 13px Interin three spots. To improve maintainability and ensure a fallback, extract a helper or constant (e.g.getCanvasFont(pv)) and append a generic fallback (for example,Inter, sans-serif).Also applies to: 44-44, 61-61
packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts (1)
5-5: DRY up font declaration and include fallback
You’re settingctx.fontandfontFamilyto${pv ? 600 : 500} 13px Inter. Consider extracting this into a shared function/constant and adding a fallback (Inter, sans-serif) for better consistency and resilience.Also applies to: 39-39
packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts (1)
26-26: Add fallback font and centralize weight logic
The static string'500 13px Inter'is used twice. To avoid duplication and ensure proper fallbacks, factor this into a shared helper/constant and append a generic fallback (Inter, sans-serif).Also applies to: 38-38
packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts (1)
27-27: Unify font setup and include fallback
You’ve updatedfontFamilyto${pv ? 600 : 500} 13px Interin two places. Consider creating a common method/constant for the canvas font string and adding a fallback likeInter, sans-serif.Also applies to: 79-79
packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts (1)
108-108: Encapsulate canvas font and add fallbacks
The offscreen and onscreen contexts both setctx.fontto${pv ? 600 : 500} 13px Inter. To reduce duplication and guarantee a fallback, consolidate this into a helper/constant and appendInter, sans-serif.Also applies to: 206-206
packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts (2)
26-26: Font family updated correctly
ThefontFamilyvalue has been switched from Manrope to Inter, preserving the existing weight logic (pv ? 600 : 500) and size (13px). This aligns with the PR’s typography update without impacting rendering logic.Consider appending a generic fallback (e.g.,
sans-serif) for increased resilience:fontFamily: `${pv ? 600 : 500} 13px Inter, sans-serif`
79-79: Consistent offscreen font in click handler
The offscreenrenderMultiLineTextcall now also uses Inter, ensuring hit-detection metrics match on-screen text measurements. No side-effects expected.Optionally include a fallback font family here as well.
packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts (3)
106-106: Ellipsis overflow text font updated
The overflow ellipsis now uses500 13px Inter, matching the updated canvas typography. Layout and truncation logic remain unchanged.Optionally add a fallback font, e.g.,
fontFamily: '500 13px Inter, sans-serif'
178-178: Initials placeholder font updated
The initials within the user icon use600 10px Inter, maintaining emphasis and centering. No rendering regressions expected.Consider appending a fallback font to guard against load failures.
203-203: User display name font updated
The user tag text now consistently applies500 13px Inter. This aligns with other renderers and keeps tag layout stable.Optionally include a fallback font in the string.
packages/nc-gui/components/smartsheet/grid/canvas/cells/index.ts (1)
295-295: Default cell fallback font updated
The fallbackrenderSingleLineTextnow uses Inter (13px, dynamic weight) instead of Manrope, ensuring consistent typography across unrecognized cell types.Optionally include a generic fallback font for resilience:
fontFamily: `${pv ? 600 : 500} 13px Inter, sans-serif`packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts (3)
33-33: Primary URL text font updated
The in‐cell URL rendering now adopts Inter (13px, dynamic weight) in place of Manrope. Visual hierarchy and underline behavior remain intact.Optional: append a fallback font family.
90-90: Hover‐tooltip text font updated
Offscreen measurement for the hover tooltip now uses Inter, preserving accurate hitbox calculations with the new font metrics.Consider adding a fallback font in the string.
137-137: Click-handler measurement font updated
The click-handler’s offscreenrenderMultiLineTextcall now also uses Inter, ensuring click regions reflect the updated typography.Optionally include a fallback font for robustness.
packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts (1)
24-24: Generic readonly renderer font updated
TheGenericReadOnlyRenderernow uses Inter (13px,pvweight logic), aligning it with other cell renderers. No logic or flow changes.Optionally include a fallback font (e.g.,
Inter, sans-serif).packages/nc-gui/assets/style/fonts.css (1)
1-2: Validate the font import path and consider fallbacksThe new
@importbrings in the Inter font definitions—please confirm that./Inter-4.1/inter.cssis correctly resolved by your build pipeline. Additionally, it’s a good practice to specify a fallback stack in your CSS rules, for example:font-family: 'Inter', sans-serif;packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts (1)
68-68: Remove redundant assignmentThe line
ctx.font = ctx.font = `500 11px Inter`duplicates the assignment. It can be simplified to:
- ctx.font = ctx.font = `500 11px Inter` + ctx.font = `500 11px Inter`packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts (4)
12-12: Include fallback fonts in canvas context font string
The canvas font is set to'400 13px Inter'. To guard against cases where Inter may not be loaded, append a generic fallback:- ctx.font = '400 13px Inter' + ctx.font = '400 13px Inter, sans-serif'
35-35: Add fallback fonts to renderSingleLineText fontFamily
ThefontFamilypassed torenderSingleLineTextis currently'600 13px Inter'. Include fallbacks to ensure text still renders if Inter fails:- fontFamily: `${pv ? 600 : 500} 13px Inter`, + fontFamily: `${pv ? 600 : 500} 13px Inter, sans-serif`,
60-60: Add fallback fonts in offscreen canvas font setting
When setting the offscreen context font, include a fallback:- canvasContext.font = '500 13px Inter' + canvasContext.font = '500 13px Inter, sans-serif'
73-73: Add fallback fonts for placeholder font in click handler
Ensure the placeholder font in the click handler has a fallback:- canvasContext.font = '400 13px Inter' + canvasContext.font = '400 13px Inter, sans-serif'packages/nc-gui/components/smartsheet/grid/canvas/index.vue (2)
795-795: Review font shorthand and include fallbacks
You’ve switched from Manrope to Inter but dropped the original/line-heightspec. Canvas text metrics may shift without it. Also append generic fallbacks:- fontFamily: `600 ${reduceFontSize ? '10px' : '12px'} Inter`, + fontFamily: `600 ${reduceFontSize ? '10px' : '12px'} Inter, sans-serif`,Please verify vertical alignment remains correct.
1572-1572: Add fallback fonts to canvas context font
Include a fallback when setting the header tooltip font:- ctx.font = '550 12px Inter' + ctx.font = '550 12px Inter, sans-serif'packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts (4)
15-15: Include fallback fonts for canvas placeholder rendering
Use a generic fallback in case Inter isn’t available:- ctx.font = '400 13px Inter' + ctx.font = '400 13px Inter, sans-serif'
49-49: Add fallback fonts in renderSingleLineText fontFamily
Ensure a fallback is provided for the font family:- fontFamily: `${pv ? 600 : 500} 13px Inter`, + fontFamily: `${pv ? 600 : 500} 13px Inter, sans-serif`,
79-79: Include fallback fonts for click handler placeholder
Append a fallback to the placeholder font in the click handler:- canvasContext.font = '400 13px Inter' + canvasContext.font = '400 13px Inter, sans-serif'
83-84: Consolidate and fallback for canvas context font
You setcanvasContext.fonttwice; consolidate into one assignment and add fallbacks:- canvasContext.font = '500 13px Inter' - canvasContext.font = '400 13px Inter' + canvasContext.font = value + ? '500 13px Inter, sans-serif' + : '400 13px Inter, sans-serif'This removes redundancy and ensures a robust fallback.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (18)
packages/nc-gui/assets/style/Inter-4.1/Inter-Black.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-BlackItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-Bold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-BoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-ExtraBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-ExtraBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-ExtraLight.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-ExtraLightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-Italic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-Light.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-LightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-Medium.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-MediumItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-Regular.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-SemiBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-SemiBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-Thin.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-ThinItalic.woff2is excluded by!**/*.woff2,!**/*.woff2
📒 Files selected for processing (40)
packages/nc-gui/assets/style/Inter-4.1/inter.css(1 hunks)packages/nc-gui/assets/style/fonts.css(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts(5 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts< 8000 /code> (1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts(4 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/index.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts(30 hunks)packages/nc-gui/components/smartsheet/grid/canvas/index.vue(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts(8 hunks)packages/nc-gui/windi.config.ts(1 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
packages/nc-gui/assets/style/Inter-4.1/inter.css
[error] 131-131: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 132-132: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 133-133: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 134-134: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 135-135: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 136-136: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 137-137: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 138-138: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 139-139: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 140-140: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 141-141: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 142-142: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 143-143: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 144-144: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 145-145: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 146-146: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 147-147: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 148-148: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 149-149: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 150-150: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 151-151: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 152-152: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 153-153: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 154-154: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 155-155: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 156-156: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 159-159: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 160-160: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 161-161: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 162-162: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 163-163: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 164-164: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 165-165: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 166-166: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 167-167: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 168-168: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 169-169: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 170-170: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 171-171: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 172-172: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 173-173: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 174-174: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: pre-build-for-playwright / playwright
- GitHub Check: unit-tests-pg
- GitHub Check: unit-tests
- GitHub Check: release-docker / buildx
🔇 Additional comments (39)
packages/nc-gui/assets/style/Inter-4.1/inter.css (1)
1-127: Font‐face declarations look solid
All weights (100–900), styles (normal/italic),font-display: swap, and.woff2URLs are correctly defined.packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts (1)
44-44: Verify button‐label weight
ctx.font = '10px Inter'omits an explicit weight (defaults to normal 400). If the design calls for a 500‐weight label to match other cells, update to'500 10px Inter'.packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts (1)
40-40: Font family update looks good!The change from Manrope to Inter while maintaining the same font weight and size structure is consistent with the PR's objective.
packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts (1)
180-180: Font family change is well implemented!Correctly updated the ellipsis text font from Manrope to Inter while preserving the same weight and size.
packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts (1)
158-158: Font family update is properly applied!The "Add File(s)" button text font has been correctly changed from Manrope to Inter.
packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts (1)
174-174: Font family change is consistent!The ellipsis text font has been properly updated from Manrope to Inter while maintaining the same weight and size structure.
packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts (1)
35-35: Updated font for button label renderingReplaced
ctx.fontfrom Manrope to Inter in thegetButtonDimensionsfunction, aligning with the revised typography across the app.packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts (1)
175-175: Updated font for ellipsis textChanged the
fontFamilyinrenderSingleLineTextfor the ellipsis ("...") from Manrope to Inter, ensuring consistent typography.packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts (1)
50-50: Updated font for ellipsis and tag textReplaced the
fontFamilyvalues in both the ellipsis rendering and tag text rendering to use Inter, maintaining consistent styling.Also applies to: 81-81
packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts (1)
14-14: Updated default font for plain cell rendererChanged the default
fontFamilyvalue to Inter in thePlainCellRenderer, matching the global typography update.packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts (1)
14-14: Updated font for QR code error messagesChanged the
fontFamilyin both error message renderings to Inter, keeping error text typography consistent.Also applies to: 31-31
packages/nc-gui/assets/style/fonts.css (1)
8-8: Correction confirmed for ManropesrcsyntaxThe missing semicolon at the end of the
srcline for the ‘Manrope’@font-facehas been added correctly, fixing the CSS syntax error.packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts (2)
259-261: Confirm font weight and sizingIn the main render path, the canvas font has been updated to use
550 13px Inter. Please ensure that the weight of 550 aligns with the design specifications—if your design system only defines standard weights (e.g., 500 or 600), adjust accordingly.
360-362: Consistent font usage for offscreen measurementsThe offscreen context now mirrors the on-screen font setup with
550 13px Interfor label width calculations, maintaining truncation accuracy.packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts (4)
18-20: Approve placeholder font updateThe placeholder rendering path correctly sets
ctx.font = '400 13px Inter'for empty-year cells, matching the intended style for inactive input text.
40-42: Approve main text font configurationThe dynamic font string for actual year values (
${pv ? 600 : 500} 13px Inter) has been updated properly, preserving the primary visual differentiation based onpv.
64-66: Approve offscreen font for valid value measurementIn the click handler, the offscreen context uses
500 13px Interto measure text width for valid year values, which corresponds to the non-pvweight path.
68-71: Approve offscreen font for placeholder measurementThe click handler correctly sets
ctx.font = '400 13px Inter'when measuring the placeholder'YYYY', matching the UI placeholder style.packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts (2)
78-80: Approve rich text font updateThe
renderMarkdowninvocation now uses the updated font familyInterwith dynamic weight (${pv ? 600 : 500} 13px), preserving previous behavior while switching the family.
106-108: Approve multi-line text font updateThe
renderMultiLineTextcall has been updated similarly to useInteras the font family, maintaining the existing weight logic.packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts (4)
11-11: Approve dynamic font setting in renderThe main render routine now toggles between
500and600weight for13px Interbased onpv, correctly reflecting the new font family update.
33-34: Approve placeholder font updateThe placeholder text path sets
ctx.font = '400 13px Inter'as expected, matching the style used for editing placeholders.
84-84: Approve offscreen font for valid date/time measurementThe offscreen context correctly uses
500 13px Interfor measuring actual date/time text widths, aligning with the render configuration.
102-103: Approve offscreen font for placeholder measurementIn the click handler’s fallback path,
canvasContext.font = '400 13px Inter'is used for measuring placeholder text, which is consistent with the placeholder styling.packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts (7)
253-253: Consistent font update in header rendering
Replaced"Manrope"with"Inter"for the headerctx.fontassignment without altering weight, size, or alignment.
873-873: Consistent fontFamily change in row meta index rendering
Updated the defaultfontFamilyfor row index rendering to use Inter (500 ${rowIndexFontSize} Inter), preserving existing styling logic.
953-953: Consistent fontFamily change for comment count bubble
Changed the comment‐count label font declaration to Inter (${reduceFontSize ? '600 10px' : '500 13px'} Inter), matching the new typography.
1043-1045: Updated inline upgrade modal fonts to Inter
Both the title (700 16px Inter) and subtitle (500 14px Inter) in the upgrade modal inline now use Inter, ensuring consistency.
1081-1096: Updated buttons in upgrade modal inline to Inter
Button labels for “Learn More” and “Upgrade/Request Upgrade” have been updated to use Inter (600 14px Inter).
1842-1867: Updated aggregation footer fonts to Inter
All aggregation footerctx.fontcalls (e.g.,'600 12px Inter','400 12px Inter','600 10px Inter') have been updated from Manrope to Inter, with no logic change.
1931-2761: Bulk fontFamily replacements
The remaining font declarations across grouping and cell rendering sections have been similarly updated to Inter. These are repetitive string swaps with no behavioral changes.packages/nc-gui/windi.config.ts (2)
82-85: Review monospaced font configuration
Themonofamily is set to['Inter','mono'], but Inter is a proportional font. Please verify if a true monospaced font (e.g., Menlo, Courier New) is intended here.
102-127: Comprehensive fontSize extension
The typography scale has been expanded with granular sizes, line heights, weights, and letter spacing. This aligns well with richer UI needs—no issues spotted.packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts (6)
378-378: Updated default fontFamily for single-line text to Inter
DefaultfontFamilyforrenderSingleLineTextchanged from Manrope to'500 13px Inter'—no other behavior modified.
834-834: Updated default fontFamily for multi-line text to Inter
DefaultfontFamilyforrenderMultiLineTextis now'500 13px Inter', preserving existing wrapping logic.
1020-1021: Updated fallback font in barcode error handling to Inter
In the barcode catch block,ctx.fontnow uses Inter. This ensures error messages match the new typography.
1034-1035: Updated fontFamily for barcode fallback text rendering to Inter
The fallbackrenderMultiLineTextin the barcode error path now uses Inter (fontFamily: '500 13px Inter').
1073-1073: Updated default fontFamily for markdown rendering to Inter
renderMarkdowndefaultfontFamilyis now'500 13px Inter', replacing Manrope.
1210-1210: Updated tagFontFamily default to Inter
InrenderTagLabel, the defaulttagFontFamilyis now'500 13px Inter'.
packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts
Outdated
Show resolved
Hide resolved
|
Uffizzi Preview |
26141d2 to
d37b0eb
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/nc-gui/assets/style/Inter-4.1/inter.css (2)
1-127: Complete and correct @font-face declarations
The set of@font-facerules covers all weights (100–900) in both normal and italic styles, and usesfont-display: swapfor good performance. Ensure that each referenced.woff2file exists in this directory and is correctly bundled by your build system.Consider replacing these multiple static files with the Inter variable font (e.g.,
Inter-VariableFont_slnt,wght.ttf.woff2) to reduce network requests and improve loading performance.
129-176: Handle@font-feature-valuessupport and lint warnings
The@font-feature-valuesblock is valid CSS Fonts Module Level 4 syntax but is flagged by Biome (noUnknownProperty) and may not be supported in all target browsers.
- Wrap the block with stylelint/biome disable comments to silence false positives:
+/* stylelint-disable property-no-unknown */ @font-feature-values Inter { /* ... */ } +/* stylelint-enable property-no-unknown */
- Verify that your browser support matrix includes
@font-feature-values, or provide fallback settings usingfont-feature-settingson relevant selectors.🧰 Tools
🪛 Biome (1.9.4)
[error] 131-131: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 132-132: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 133-133: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 134-134: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 135-135: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 136-136: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 137-137: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 138-138: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 139-139: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 140-140: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 141-141: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 142-142: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 143-143: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 144-144: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 145-145: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 146-146: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 147-147: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 148-148: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 149-149: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 150-150: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 151-151: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 152-152: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 153-153: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 154-154: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 155-155: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 156-156: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 159-159: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 160-160: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 161-161: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 162-162: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 163-163: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 164-164: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 165-165: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 166-166: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 167-167: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 168-168: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 169-169: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 170-170: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 171-171: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 172-172: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 173-173: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 174-174: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (18)
packages/nc-gui/assets/style/Inter-4.1/Inter-Black.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-BlackItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-Bold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-BoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-ExtraBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-ExtraBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-ExtraLight.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-ExtraLightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-Italic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-Light.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-LightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-Medium.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-MediumItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-Regular.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-SemiBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-SemiBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-Thin.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-4.1/Inter-ThinItalic.woff2is excluded by!**/*.woff2,!**/*.woff2
📒 Files selected for processing (40)
packages/nc-gui/assets/style/Inter-4.1/inter.css(1 hunks)packages/nc-gui/assets/style/fonts.css(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts(5 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts(4 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/index.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts(30 hunks)packages/nc-gui/components/smartsheet/grid/canvas/index.vue(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts(8 hunks)packages/nc-gui/windi.config.ts(1 hunks)
✅ Files skipped from review due to trivial changes (9)
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts
🚧 Files skipped from review as they are similar to previous changes (30)
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts
- packages/nc-gui/assets/style/fonts.css
- packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/index.ts
- packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts
- packages/nc-gui/windi.config.ts
- packages/nc-gui/components/smartsheet/grid/canvas/index.vue
- packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts
🧰 Additional context used
🪛 Biome (1.9.4)
packages/nc-gui/assets/style/Inter-4.1/inter.css
[error] 131-131: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 132-132: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 133-133: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more detai
A93C
ls.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 134-134: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 135-135: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 136-136: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 137-137: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 138-138: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 139-139: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 140-140: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 141-141: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 142-142: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 143-143: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 144-144: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 145-145: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 146-146: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 147-147: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 148-148: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 149-149: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 150-150: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 151-151: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 152-152: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 153-153: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 154-154: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 155-155: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 156-156: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 159-159: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 160-160: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 161-161: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 162-162: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 163-163: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 164-164: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 165-165: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 166-166: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 167-167: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 168-168: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 169-169: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 170-170: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 171-171: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 172-172: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 173-173: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 174-174: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: pre-build-for-playwright / playwright
- GitHub Check: unit-tests-pg
- GitHub Check: unit-tests
- GitHub Check: release-docker / buildx
d37b0eb to
41bc2be
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (18)
packages/nc-gui/assets/style/Inter-new/Inter-Black.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-BlackItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Bold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-BoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraLight.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraLightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Italic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Light.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-LightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Medium.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-MediumItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Regular.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-SemiBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-SemiBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Thin.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ThinItalic.woff2is excluded by!**/*.woff2,!**/*.woff2
📒 Files selected for processing (42)
packages/nc-gui/assets/style/Inter-new/inter.css(1 hunks)packages/nc-gui/assets/style/fonts-new.css(1 hunks)packages/nc-gui/assets/style/fonts.css(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts(5 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts(4 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/index.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts(30 hunks)packages/nc-gui/components/smartsheet/grid/canvas/index.vue(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts(8 hunks)packages/nc-gui/nuxt.config.ts(1 hunks)packages/nc-gui/windi.config.ts(1 hunks)
✅ Files skipped from review due to trivial changes (15)
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts
- packages/nc-gui/nuxt.config.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts
- packages/nc-gui/assets/style/fonts.css
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts
- packages/nc-gui/assets/style/fonts-new.css
- packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts
🚧 Files skipped from review as they are similar to previous changes (25)
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts
- packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/index.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts
- packages/nc-gui/components/smartsheet/grid/canvas/index.vue
- packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts
- packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts
🧰 Additional context used
🪛 Biome (1.9.4)
packages/nc-gui/assets/style/Inter-new/inter.css
[error] 131-131: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 132-132: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 133-133: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 134-134: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 135-135: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 136-136: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 137-137: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 138-138: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 139-139: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 140-140: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 141-141: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 142-142: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 143-143: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 144-144: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 145-145: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 146-146: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 147-147: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 148-148: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 149-149: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 150-150: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 151-151: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 152-152: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 153-153: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 154-154: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 155-155: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 156-156: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 159-159: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 160-160: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 161-161: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 162-162: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 163-163: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 164-164: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 165-165: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 166-166: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 167-167: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 168-168: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 169-169: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 170-170: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 171-171: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 172-172: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 173-173: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 174-174: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
🔇 Additional comments (2)
packages/nc-gui/assets/style/Inter-new/inter.css (1)
1-127: Well-structured font-face declarations for Inter font family.The implementation includes a comprehensive set of @font-face declarations covering all weights (100-900) and styles (normal/italic), using the efficient woff2 format with font-display: swap for optimal loading performance.
packages/nc-gui/windi.config.ts (1)
102-126: Excellent typography system implementation.The expanded fontSize configuration creates a comprehensive typography system with consistent patterns for headings, body text, and captions. This structured approach will improve UI consistency across the application, with properly defined:
- Font sizes and line heights
- Font weights (400 for regular, 600 for bold)
- Letter spacing (-2% for headings, 0% for body text)
- Specialized text styles for different UI contexts
This is a significant improvement over the previous minimal configuration and aligns well with the font change from Manrope to Inter.
41bc2be to
0c84bc7
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
packages/nc-gui/assets/style/Inter-new/inter.css (1)
129-176: Add cross-browser fallback for OpenType feature values
The@font-feature-valuesat-rule is only natively supported in Firefox and Safari. To ensure your character variants and stylistic sets apply in Chrome, Edge, Opera, and many mobile browsers, add a fallback usingfont-feature-settings. For example, right after line 176 you could append:@supports not (font-feature-settings: "cv01" 1) { .inter-text { font-feature-settings: "cv01" 1, "cv02" 2, "cv03" 3, /* … etc. … */ "ss01" 1, "ss02" 2, "open-digits" 1 /* … etc. … */; } }This ensures consistent OpenType feature application across all browsers.
🧰 Tools
🪛 Biome (1.9.4)
[error] 131-131: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 132-132: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 133-133: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 134-134: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 135-135: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 136-136: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 137-137: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 138-138: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 139-139: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 140-140: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 141-141: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 142-142: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 143-143: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 144-144: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 145-145: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 146-146: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 147-147: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 148-148: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 149-149: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 150-150: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 151-151: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 152-152: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 153-153: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 154-154: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 155-155: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 156-156: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 159-159: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 160-160: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 161-161: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 162-162: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 163-163: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 164-164: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 165-165: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 166-166: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 167-167: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 168-168: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 169-169: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 170-170: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 171-171: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 172-172: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 173-173: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 174-174: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (18)
packages/nc-gui/assets/style/Inter-new/Inter-Black.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-BlackItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Bold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-BoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraLight.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraLightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Italic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Light.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-LightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Medium.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-MediumItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Regular.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-SemiBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-SemiBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Thin.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ThinItalic.woff2is excluded by!**/*.woff2,!**/*.woff2
📒 Files selected for processing (42)
packages/nc-gui/assets/style/Inter-new/inter.css(1 hunks)packages/nc-gui/assets/style/fonts-new.css(1 hunks)packages/nc-gui/assets/style/fonts.css(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts(5 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts(4 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/index.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts(30 hunks)packages/nc-gui/components/smartsheet/grid/canvas/index.vue(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts(8 hunks)packages/nc-gui/nuxt.config.ts(1 hunks)packages/nc-gui/windi.config.ts(1 hunks)
✅ Files skipped from review due to trivial changes (13)
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts
- packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts
- packages/nc-gui/assets/style/fonts.css
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts
- packages/nc-gui/components/smartsheet/grid/canvas/index.vue
- packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts
🚧 Files skipped from review as they are similar to previous changes (28)
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts
- packages/nc-gui/nuxt.config.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells 10000 /index.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts
- packages/nc-gui/windi.config.ts
- packages/nc-gui/assets/style/fonts-new.css
- packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts
- packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts
🧰 Additional context used
🪛 Biome (1.9.4)
packages/nc-gui/assets/style/Inter-new/inter.css
[error] 131-131: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 132-132: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 133-133: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 134-134: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 135-135: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 136-136: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 137-137: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 138-138: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 139-139: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 140-140: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 141-141: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 142-142: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 143-143: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 144-144: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 145-145: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 146-146: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 147-147: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 148-148: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 149-149: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 150-150: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 151-151: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 152-152: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 153-153: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 154-154: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 155-155: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 156-156: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 159-159: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 160-160: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 161-161: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 162-162: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 163-163: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 164-164: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 165-165: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 166-166: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 167-167: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 168-168: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 169-169: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 170-170: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 171-171: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 172-172: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 173-173: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 174-174: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: release-docker / buildx
- GitHub Check: unit-tests-pg
- GitHub Check: unit-tests
|
Test comment |
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (3)
packages/nc-gui/assets/style/Inter-new/inter.css (3)
129-176: Add cross-browser fallback and suppress lint warnings for @font-feature-values
The@font-feature-valuesblock is only supported in Firefox and Safari, and Biome reports unknown-property errors. To improve compatibility and silence false positives, you can:
- Wrap the block with Biome directives to disable
noUnknownProperty.- Add a
@supports not (font-feature-settings: "cv01" 1)fallback usingfont-feature-settingsto cover other browsers./* biome-disable correctness/noUnknownProperty */ @font-feature-values Inter { /* ... existing character-variant and styleset declarations ... */ } /* biome-enable correctness/noUnknownProperty */ /* Fallback for browsers without @font-feature-values support */ @supports not (font-feature-settings: "cv01" 1) { .inter-text, /* adjust selectors as needed */ [class*="inter-"] { font-feature-settings: "cv01" 1, "cv02" 2, "cv03" 3, "cv04" 4, "cv05" 5, "cv06" 6, "cv07" 7, "cv08" 8, "cv09" 9, "cv10" 10, "cv11" 11, "cv12" 12, "cv13" 13, "ss01" 1, "ss02" 2, "ss03" 3, "ss04" 4, "ss05" 5, "ss06" 6, "ss07" 7, "ss08" 8, "open-digits" 1, "disambiguation" 2, "round-quotes-and-commas" 3; } }🧰 Tools
🪛 Biome (1.9.4)
[error] 131-131: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 132-132: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 133-133: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 134-134: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 135-135: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 136-136: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 137-137: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 138-138: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 139-139: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 140-140: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 141-141: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 142-142: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 143-143: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 144-144: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 145-145: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 146-146: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 147-147: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 148-148: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 149-149: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 150-150: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 151-151: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 152-152: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 153-153: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 154-154: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 155-155: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 156-156: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 159-159: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 160-160: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 161-161: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 162-162: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 163-163: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 164-164: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 165-165: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 166-166: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 167-167: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 168-168: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 169-169: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 170-170: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 171-171: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 172-172: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 173-173: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 174-174: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
73-84:⚠️ Potential issueFix font-weight 600 asset mapping
The declarations for weight 600 are referencingInter-Mediumfiles, which correspond to weight 500. To correctly map to weight 600 (SemiBold), update thesrcURLs toInter-SemiBold.woff2/Inter-SemiBoldItalic.woff2.@font-face { font-family: 'Inter'; font-style: normal; - font-weight: 600; - src: url('./Inter-Medium.woff2') format('woff2'); + font-weight: 600; /* SemiBold */ + src: url('./Inter-SemiBold.woff2') format('woff2'); } @font-face { font-family: 'Inter'; font-style: italic; - font-weight: 600; - src: url('./Inter-MediumItalic.woff2') format('woff2'); + font-weight: 600; /* SemiBold */ + src: url('./Inter-SemiBoldItalic.woff2') format('woff2'); }
114-127:⚠️ Potential issueFix font-weight 900 asset mapping
Weight 900 is declared but loading the ExtraBold variant (800). If a Black (900) font file exists, point toInter-Black.woff2/Inter-BlackItalic.woff2; otherwise, adjust the declared weight to 800.@font-face { font-family: 'Inter'; font-style: normal; - font-weight: 900; - src: url('./Inter-ExtraBold.woff2') format('woff2'); + font-weight: 900; /* Black */ + src: url('./Inter-Black.woff2') format('woff2'); } @font-face { font-family: 'Inter'; font-style: italic; - font-weight: 900; - src: url('./Inter-ExtraBoldItalic.woff2') format('woff2'); + font-weight: 900; /* Black */ + src: url('./Inter-BlackItalic.woff2') format('woff2'); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (18)
packages/nc-gui/assets/style/Inter-new/Inter-Black.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-BlackItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Bold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-BoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraLight.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraLightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Italic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Light.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-LightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Medium.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-MediumItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Regular.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-SemiBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-SemiBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Thin.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ThinItalic.woff2is excluded by!**/*.woff2,!**/*.woff2
📒 Files selected for processing (42)
packages/nc-gui/assets/style/Inter-new/inter.css(1 hunks)packages/nc-gui/assets/style/fonts-new.css(1 hunks)packages/nc-gui/assets/style/fonts.css(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts(5 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts(4 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/index.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts(30 hunks)packages/nc-gui/components/smartsheet/grid/canvas/index.vue(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts(8 hunks)packages/nc-gui/nuxt.config.ts(2 hunks)packages/nc-gui/windi.config.ts(1 hunks)
✅ Files skipped from review due to trivial changes (6)
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts
🚧 Files skipped from review as they are similar to previous changes (35)
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts
- packages/nc-gui/assets/style/fonts.css
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts
- packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/index.ts
- packages/nc-gui/nuxt.config.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts
- packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts
- packages/nc-gui/components/smartsheet/grid/canvas/index.vue
- packages/nc-gui/windi.config.ts
- packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts
- packages/nc-gui/assets/style/fonts-new.css
🧰 Additional context used
🪛 Biome (1.9.4)
packages/nc-gui/assets/style/Inter-new/inter.css
[error] 131-131: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 132-132: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 133-133: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 134-134: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 135-135: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 136-136: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 137-137: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 138-138: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 139-139: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 140-140: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 141-141: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 142-142: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 143-143: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 144-144: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 145-145: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 146-146: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 147-147: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 148-148: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 149-149: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 150-150: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 151-151: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 152-152: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 153-153: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 154-154: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 155-155: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 156-156: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 159-159: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 160-160: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 161-161: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 162-162: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 163-163: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 164-164: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 165-165: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 166-166: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 167-167: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 168-168: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 169-169: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 170-170: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 171-171: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 172-172: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 173-173: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 174-174: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: release-docker / buildx
- GitHub Check: pre-build-for-playwright / playwright
- GitHub Check: unit-tests-pg
- GitHub Check: unit-tests
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (3)
packages/nc-gui/assets/style/Inter-new/inter.css (3)
129-176: 🛠️ Refactor suggestionAdd cross-browser fallback and ignore false positives.
The@font-feature-valuesblock is valid CSS—Biome’s “unknown property” errors can be ignored here. However, most browsers (Chrome, Edge, Opera, mobile) don’t support@font-feature-values. Please include a fallback:@supports not (font-feature-settings: 'cv01' 1) { /* Fallback for browsers without @font-feature-values */ :root { font-feature-settings: 'cv01' 1, 'cv02' 2, 'cv03' 3, 'cv04' 4, 'cv05' 5, 'cv06' 6, 'cv07' 7, 'cv08' 8, 'cv09' 9, 'cv10' 10, 'cv11' 11, 'cv12' 12, 'cv13' 13; } }🧰 Tools
🪛 Biome (1.9.4)
[error] 131-131: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 132-132: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 133-133: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 134-134: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 135-135: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 136-136: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 137-137: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 138-138: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 139-139: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 140-140: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 141-141: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 142-142: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 143-143: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 144-144: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 145-145: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 146-146: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 147-147: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 148-148: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 149-149: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 150-150: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 151-151: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 152-152: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 153-153: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 154-154: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 155-155: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 156-156: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 159-159: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 160-160: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 161-161: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 162-162: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 163-163: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 164-164: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 165-165: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 166-166: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 167-167: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 168-168: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 169-169: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 170-170: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 171-171: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 172-172: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 173-173: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 174-174: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
86-99:⚠️ Potential issueFix asset mapping for weight 700 (Bold).
The declarations use SemiBold files for weight 700; they should point to Bold:@font-face { font-family: 'Inter'; font-style: normal; - font-weight: 700; - src: url('./Inter-SemiBold.woff2') format('woff2'); + font-weight: 700; + src: url('./Inter-Bold.woff2') format('woff2'); } @font-face { font-family: 'Inter'; font-style: italic; - font-weight: 700; - src: url('./Inter-SemiBoldItalic.woff2') format('woff2'); + font-weight: 700; + src: url('./Inter-BoldItalic.woff2') format('woff2'); }
72-84:⚠️ Potential issueCorrect font-face declarations for weight 600 (SemiBold).
Currently reuses the Medium assets (weight 500). Replace with SemiBold:@font-face { font-family: 'Inter'; font-style: normal; - font-weight: 600; - src: url('./Inter-Medium.woff2') format('woff2'); + font-weight: 600; + src: url('./Inter-SemiBold.woff2') format('woff2'); } @font-face { font-family: 'Inter'; font-style: italic; - font-weight: 600; - src: url('./Inter-MediumItalic.woff2') format('woff2'); + font-weight: 600; + src: url('./Inter-SemiBoldItalic.woff2') format('woff2'); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (18)
packages/nc-gui/assets/style/Inter-new/Inter-Black.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-BlackItalic.woff2is excluded F438 by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Bold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-BoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraLight.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraLightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Italic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Light.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-LightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Medium.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-MediumItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Regular.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-SemiBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-SemiBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Thin.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ThinItalic.woff2is excluded by!**/*.woff2,!**/*.woff2
📒 Files selected for processing (42)
packages/nc-gui/assets/style/Inter-new/inter.css(1 hunks)packages/nc-gui/assets/style/fonts-new.css(1 hunks)packages/nc-gui/assets/style/fonts.css(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts(5 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts(4 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/index.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts(30 hunks)packages/nc-gui/components/smartsheet/grid/canvas/index.vue(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts(8 hunks)packages/nc-gui/nuxt.config.ts(2 hunks)packages/nc-gui/windi.config.ts(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts
- packages/nc-gui/components/smartsheet/grid/canvas/index.vue
🚧 Files skipped from review as they are similar to previous changes (36)
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts
- packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/index.ts
- packages/nc-gui/assets/style/fonts.css
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts
- packages/nc-gui/nuxt.config.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts
- packages/nc-gui/windi.config.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts
- packages/nc-gui/assets/style/fonts-new.css
- packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts
- packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts
🧰 Additional context used
🪛 Biome (1.9.4)
packages/nc-gui/assets/style/Inter-new/inter.css
[error] 131-131: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 132-132: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 133-133: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 134-134: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 135-135: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 136-136: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 137-137: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 138-138: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 139-139: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 140-140: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 141-141: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 142-142: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 143-143: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 144-144: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 145-145: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 146-146: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 147-147: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 148-148: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 149-149: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 150-150: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 151-151: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 152-152: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 153-153: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 154-154: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 155-155: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 156-156: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 159-159: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 160-160: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 161-161: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 162-162: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 163-163: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 164-164: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 165-165: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 166-166: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 167-167: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 168-168: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 169-169: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 170-170: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 171-171: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 172-172: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 173-173: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 174-174: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: release-docker / buildx
- GitHub Check: pre-build-for-playwright / playwright
- GitHub Check: unit-tests-pg
- GitHub Check: unit-tests
🔇 Additional comments (6)
packages/nc-gui/assets/style/Inter-new/inter.css (6)
1-15: Font-face declarations for weight 100 (Thin) are correctly configured.
TheInter-Thin.woff2andInter-ThinItalic.woff2assets align with the declaredfont-weight: 100and includefont-display: swapfor optimal loading.
16-29: Font-face declarations for weight 200 (ExtraLight) are properly set.
TheInter-ExtraLight.woff2andInter-ExtraLightItalic.woff2files correctly map tofont-weight: 200.
30-43: Font-face declarations for weight 300 (Light) are accurate.
TheInter-Light.woff2andInter-LightItalic.woff2assets matchfont-weight: 300.
44-57: Font-face declarations for weight 400 (Regular) are correct.
TheInter-Regular.woff2andInter-Italic.woff2files properly supportfont-weight: 400.
100-113: Font-face declarations for weight 800 (ExtraBold) are correct.
TheInter-Bold.woff2andInter-BoldItalic.woff2files map tofont-weight: 800, andfont-display: swapis applied as expected.
114-127: Verify font assets for weight 900 (Black).
The declarations useInter-ExtraBoldassets for weight 900, but ExtraBold is typically weight 800. If a Black variant exists, update to:@font-face { font-family: 'Inter'; font-style: normal; - font-weight: 900; - src: url('./Inter-ExtraBold.woff2') format('woff2'); + font-weight: 900; + src: url('./Inter-Black.woff2') format('woff2'); } @font-face { font-family: 'Inter'; font-style: italic; - font-weight: 900; - src: url('./Inter-ExtraBoldItalic.woff2') format('woff2'); + font-weight: 900; + src: url('./Inter-BlackItalic.woff2') format('woff2'); }If no Black files are available, please document why the ExtraBold assets are used for
font-weight: 900.
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (4)
packages/nc-gui/assets/style/Inter-new/inter.css (4)
100-113:⚠️ Potential issueIncorrect mapping for weight 800 (ExtraBold) variant
Declaredfont-weight: 800is using the Bold files (700). Update to the ExtraBold assets:@font-face { font-family: 'Inter'; font-style: normal; font-weight: 800; font-display: swap; - src: url('./Inter-Bold.woff2') format('woff2'); + src: url('./Inter-ExtraBold.woff2') format('woff2'); } @font-face { font-family: 'Inter'; font-style: italic; font-weight: 800; font-display: swap; - src: url('./Inter-BoldItalic.woff2') format('woff2'); + src: url('./Inter-ExtraBoldItalic.woff2') format('woff2'); }
86-99:⚠️ Potential issueIncorrect mapping for weight 700 (Bold) variant
The block labelsfont-weight: 700but points to the SemiBold files (600). It should use the Bold assets:@font-face { font-family: 'Inter'; font-style: normal; font-weight: 700; font-display: swap; - src: url('./Inter-SemiBold.woff2') format('woff2'); + src: url('./Inter-Bold.woff2') format('woff2'); } @font-face { font-family: 'Inter'; font-style: italic; font-weight: 700; font-display: swap; - src: url('./Inter-SemiBoldItalic.woff2') format('woff2'); + src: url('./Inter-BoldItalic.woff2') format('woff2'); }
114-127:⚠️ Potential issueIncorrect mapping for weight 900 (Black) variant
Thefont-weight: 900block points to the ExtraBold files (800). It should reference the Black assets:@font-face { font-family: 'Inter'; font-style: normal; font-weight: 900; font-display: swap; - src: url('./Inter-ExtraBold.woff2') format('woff2'); + src: url('./Inter-Black.woff2') format('woff2'); } @font-face { font-family: 'Inter'; font-style: italic; font-weight: 900; font-display: swap; - src: url('./Inter-ExtraBoldItalic.woff2') format('woff2'); + src: url('./Inter-BlackItalic.woff2') format('woff2'); }
58-71:⚠️ Potential issueMismatch between weight 500 and asset filenames
The block declaresfont-weight: 500but still referencesInter-Regular.woff2/Inter-Italic.woff2(weight 400). Update to the Medium assets to reflect weight 500:@font-face { font-family: 'Inter'; font-style: normal; font-weight: 500; font-display: swap; - src: url('./Inter-Regular.woff2') format('woff2'); + src: url('./Inter-Medium.woff2') format('woff2'); } @font-face { font-family: 'Inter'; font-style: italic; font-weight: 500; font-display: swap; - src: url('./Inter-Italic.woff2') format('woff2'); + src: url('./Inter-MediumItalic.woff2') format('woff2'); }
🧹 Nitpick comments (1)
packages/nc-gui/assets/style/Inter-new/inter.css (1)
129-176: Add cross-browser fallback for OpenType feature values
The@font-feature-valuesat-rule is valid but only supported in Firefox and Safari. For Chrome, Edge, Opera, and most mobile browsers, consider adding a fallback usingfont-feature-settings:@font-feature-values Inter { /* ... existing character-variant & styleset definitions ... */ } + +/* Fallback for browsers without @font-feature-values support */ +@supports not (font-feature-settings: "cv01" 1) { + :root { + font-feature-settings: + "cv01" 1, "cv02" 2, "cv03" 3, "cv04" 4, + "cv05" 5, "cv06" 6, "cv07" 7, "cv08" 8, + "cv09" 9, "cv10" 10, "cv11" 11, "cv12" 12, + "cv13" 13; + } +}This ensures the same typographic features apply universally and addresses the Biome “unknown property” warnings as false positives.
🧰 Tools
🪛 Biome (1.9.4)
[error] 131-131: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 132-132: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 133-133: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 134-134: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 135-135: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 136-136: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 137-137: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 138-138: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 139-139: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 140-140: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 141-141: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 142-142: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 143-143: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 144-144: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 145-145: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 146-146: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 147-147: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 148-148: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 149-149: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 150-150: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 151-151: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 152-152: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 153-153: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 154-154: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 155-155: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 156-156: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 159-159: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 160-160: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 161-161: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 162-162: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 163-163: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 164-164: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 165-165: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 166-166: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 167-167: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 168-168: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 169-169: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 170-170: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 171-171: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 172-172: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 173-173: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 174-174: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (18)
packages/nc-gui/assets/style/Inter-new/Inter-Black.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-BlackItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Bold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-BoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraLight.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraLightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Italic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Light.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-LightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Medium.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-MediumItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Regular.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-SemiBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-SemiBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Thin.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ThinItalic.woff2is excluded by!**/*.woff2,!**/*.woff2
📒 Files selected for processing (42)
packages/nc-gui/assets/style/Inter-new/inter.css(1 hunks)packages/nc-gui/assets/style/fonts-new.css(1 hunks)packages/nc-gui/assets/style/fonts.css(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts(5 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts(4 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/index.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts(30 hunks)packages/nc-gui/components/smartsheet/grid/canvas/index.vue(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts(8 hunks)packages/nc-gui/nuxt.config.ts(2 hunks)packages/nc-gui/windi.config.ts(1 hunks)
✅ Files skipped from review due to trivial changes (8)
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts
- packages/nc-gui/assets/style/fonts.css
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts
- packages/nc-gui/nuxt.config.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts
- packages/nc-gui/components/smartsheet/grid/canvas/index.vue
- packages/nc-gui/assets/style/fonts-new.css
🚧 Files skipped from review as they are similar to previous changes (33)
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts
- packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/index.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts
- packages/nc-gui/windi.config.ts
- packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts
- packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts
🧰 Additional context used
🪛 Biome (1.9.4)
packages/nc-gui/assets/style/Inter-new/inter.css
[error] 131-131: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 132-132: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 133-133: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 134-134: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 135-135: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 136-136: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 137-137: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 138-138: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 139-139: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 140-140: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 141-141: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 142-142: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 143-143: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 144-144: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 145-145: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 146-146: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 147-147: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 148-148: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 149-149: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 150-150: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 151-151: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 152-152: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 153-153: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 154-154: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 155-155: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 156-156: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 159-159: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 160-160: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 161-161: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 162-162: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 163-163: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 164-164: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 165-165: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 166-166: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 167-167: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 168-168: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 169-169: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 170-170: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 171-171: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 172-172: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 173-173: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 174-174: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: release-docker / buildx
- GitHub Check: pre-build-for-playwright / playwright
- GitHub Check: unit-tests-pg
- GitHub Check: unit-tests
🔇 Additional comments (2)
packages/nc-gui/assets/style/Inter-new/inter.css (2)
1-57: Font-face declarations for weights 100–400 look correct
The mapping between declaredfont-weightvalues and the corresponding Inter font files (Thin, ExtraLight, Light, Regular) is accurate, andfont-display: swapis applied consistently.
72-85: Font-face declarations for weight 600 are correct
The Medium assets are properly used forfont-weight: 600, matching naming conventions.
b394ae8 to
df43992
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/nc-gui/assets/style/Inter-new/inter.css (2)
44-57: Optimize variable font serving with WOFF2
Multiple variable font declarations (weights 350, 450, 550, 650, 750, 850, 950) currently load TrueType files, which are larger. If WOFF2 variable fonts (InterVariable.woff2) are available, switching to WOFF2 can greatly improve compression and load times:- src: url('./InterVariable.ttf') format('truetype'); + src: url('./InterVariable.woff2') format('woff2');Please update all variable font declarations accordingly.
Also applies to: 72-85, 100-113, 129-142, 157-170, 185-198, 213-226
235-282: Suppress CSS linter false positives for@font-feature-values
The@font-feature-valuesblock is valid but triggers Biome’snoUnknownPropertywarnings. To silence these false positives, wrap the block with disable/enable comments:+/* biome-disable lint/correctness/noUnknownProperty */ @font-feature-values Inter { /* …named character-variant and styleset definitions… */ } +/* biome-enable lint/correctness/noUnknownProperty */Alternatively, update your Biome configuration to allow
@font-feature-values.🧰 Tools
🪛 Biome (1.9.4)
[error] 237-237: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 238-238: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 239-239: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 240-240: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 241-241: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 242-242: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 243-243: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 244-244: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 245-245: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 246-246: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 247-247: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 248-248: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 249-249: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 250-250: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 251-251: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 252-252: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 253-253: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 254-254: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 255-255: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 256-256: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 257-257: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 258-258: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 259-259: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 260-260: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 261-261: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 262-262: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 265-265: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 266-266: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 267-267: Unknown property is 10000 not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 268-268: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 269-269: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 270-270: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 271-271: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 272-272: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 273-273: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 274-274: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 275-275: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 276-276: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 277-277: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 278-278: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 279-279: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 280-280: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (18)
packages/nc-gui/assets/style/Inter-new/Inter-Black.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-BlackItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Bold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-BoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraLight.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraLightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Italic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Light.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-LightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Medium.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-MediumItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Regular.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-SemiBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-SemiBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Thin.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ThinItalic.woff2is excluded by!**/*.woff2,!**/*.woff2
📒 Files selected for processing (46)
packages/nc-gui/assets/css/global.css(2 hunks)packages/nc-gui/assets/style/Inter-new/inter.css(1 hunks)packages/nc-gui/assets/style/fonts-new.css(1 hunks)packages/nc-gui/assets/style/fonts.css(1 hunks)packages/nc-gui/components/smartsheet/FormulaWrapperCell.vue(1 hunks)packages/nc-gui/components/smartsheet/column/FormulaInputHelper.vue(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts(5 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts(4 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/index.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts(30 hunks)packages/nc-gui/components/smartsheet/grid/canvas/index.vue(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts(10 hunks)packages/nc-gui/nuxt.config.ts(2 hunks)packages/nc-gui/windi.config.ts(2 hunks)packages/nocodb/src/services/mail/templates/components/RootWrapper.tsx(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- packages/nc-gui/components/smartsheet/column/FormulaInputHelper.vue
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts
- packages/nc-gui/components/smartsheet/grid/canvas/index.vue
🚧 Files skipped from review as they are similar to previous changes (42)
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts
- packages/nc-gui/assets/style/fonts.css
- packages/nc-gui/components/smartsheet/FormulaWrapperCell.vue
- packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts
- packages/nocodb/src/services/mail/templates/components/RootWrapper.tsx
- packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts
- packages/nc-gui/nuxt.config.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts
- packages/nc-gui/assets/css/global.css
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/index.ts
- packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts
- packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts
- packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts
- packages/nc-gui/assets/style/fonts-new.css
- packages/nc-gui/windi.config.ts
🧰 Additional context used
🧠 Learnings (1)
packages/nc-gui/assets/style/Inter-new/inter.css (2)
Learnt from: rameshmane7218
PR: nocodb/nocodb#11259
File: packages/nc-gui/assets/style/Inter-new/inter.css:58-71
Timestamp: 2025-05-01T07:00:31.875Z
Learning: In the Inter font implementation in NocoDB, weight 500 intentionally uses Regular files (weight 400), weight 600 uses Medium files, weight 800 uses Bold files, etc. This weight remapping is deliberate to ensure visual consistency during the transition from Manrope to Inter fonts, since Inter naturally appears bolder than Manrope at equivalent weights.
Learnt from: rameshmane7218
PR: nocodb/nocodb#11259
File: packages/nc-gui/assets/style/Inter-new/inter.css:0-0
Timestamp: 2025-05-01T07:00:07.284Z
Learning: In the NocoDB project, the Inter font weights are intentionally mapped differently than standard (using Medium files for weight 600, Bold for weight 800, etc.) to maintain visual consistency with the previous Manrope font, as Inter's natural weights appear bolder than Manrope's equivalent weights.
🪛 Biome (1.9.4)
packages/nc-gui/assets/style/Inter-new/inter.css
[error] 237-237: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 238-238: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 239-239: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 240-240: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 241-241: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 242-242: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 243-243: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 244-244: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 245-245: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 246-246: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 247-247: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 248-248: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 249-249: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 250-250: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 251-251: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 252-252: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 253-253: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 254-254: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 255-255: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 256-256: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 257-257: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 258-258: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 259-259: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 260-260: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 261-261: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 262-262: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 265-265: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 266-266: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 267-267: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 268-268: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 269-269: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 270-270: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 271-271: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 272-272: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 273-273: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 274-274: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 275-275: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 276-276: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 277-277: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 278-278: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 279-279: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 280-280: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: release-docker / buildx
- GitHub Check: pre-build-for-playwright / playwright
- GitHub Check: unit-tests-pg
- GitHub Check: unit-tests
🔇 Additional comments (9)
packages/nc-gui/assets/style/Inter-new/inter.css (9)
1-43: Static weight (100–300) declarations look correct
The@font-faceblocks for weights 100 (Thin), 200 (ExtraLight), and 300 (Light) (normal and italic) properly reference.woff2assets and usefont-display: swapfor optimal rendering performance.
58-71: Standard weight (400) mapping aligns with base design
The weight 400 declarations correctly useInter-RegularandInter-Italicassets, maintaining the intended baseline appearance.
86-99: Custom weight 500 mapping is intentional
As noted in the project learnings, mapping weight 500 to theInter-Regularassets (400) preserves the visual consistency established by the previous Manrope font.
115-128: Medium weight (600) mapping follows project guidelines
Retrieved learnings confirm that usingInter-Mediumfor weight 600 is a deliberate choice to match Manrope’s relative weight distribution.
143-156: SemiBold weight (700) mapping intentionally remapped
UsingInter-SemiBoldfor weight 700 is by design to maintain consistent visual hierarchy with the original font set.
171-184: Bold weight (800) mapping aligns with retrieved learnings
TheInter-Boldasset for weight 800 ensures the desired boldness without overemphasis compared to Manrope’s equivalent weight.
199-212: ExtraBold weight (900) mapping is correct per style guidelines
The weight 900 declarations correctly useInter-ExtraBoldassets, preserving the intended typographic hierarchy.
228-233: Global fallback for OpenType features is correctly applied
Settingfont-feature-settingson thehtmlelement ensures character variants (cv01–cv13) are enabled across all browsers, providing a robust fallback.
284-289: Numeric alignment for form controls
Enforcingfont-variant-numeric: tabular-numsoninput,textarea,select, andbuttonelements ensures consistent numeric layout in forms.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/nc-gui/assets/style/Inter-new/inter.css (4)
2-43: Confirm light-weight font-face definitions.
The declarations for weights 100, 200, and 300 (normal and italic) are correctly defined withfont-display: swap. If you need to support older browsers, consider adding legacy.wofffallbacks alongside your.woff2files.
44-57: Reduce redundancy by consolidating variable font declarations.
You have separate@font-faceblocks for variable weights at 350, 450, 550, 650, 750, 850, and 950. Merge these into two declarations (normal and italic) using a weight range to simplify maintenance and shrink your CSS:-@font-face { - font-family: 'Inter'; - font-style: normal; - font-weight: 350; - font-display: swap; - src: url('./InterVariable.ttf') format('truetype'); -} -… (repeat for each weight) … +@font-face { + font-family: 'Inter'; + font-style: normal; + font-weight: 350 950; + font-display: swap; + src: url('./InterVariable.ttf') format('truetype'); +} +@font-face { + font-family: 'Inter'; + font-style: italic; + font-weight: 350 950; + font-display: swap; + src: url('./InterVariable.ttf') format('truetype'); +}Also applies to: 72-85, 100-113, 129-140, 157-168, 185-197, 213-226
86-99: Document intentional weight remapping.
Weights 500, 600, 700, 800, and 900 are mapped non-standardly (e.g.,500→Regular,600→Medium, etc.) to match Manrope’s visual weight. Please add a comment above these blocks explaining this hack so future maintainers understand the rationale.Also applies to: 115-128, 143-156, 171-184, 199-212
235-282: Note on browser support for@font-feature-values.
This at-rule is only supported in Firefox and Safari—other engines ignore it. Static analysis warnings about unknown properties can be safely ignored. Your global fallback already covers unsupported browsers, but you may optionally document this limitation here.🧰 Tools
🪛 Biome (1.9.4)
[error] 237-237: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 238-238: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 239-239: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 240-240: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 241-241: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 242-242: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 243-243: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 244-244: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 245-245: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 246-246: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 247-247: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 248-248: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 249-249: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 250-250: Unknown property is not allowed.
See 10000 CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 251-251: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 252-252: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 253-253: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 254-254: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 255-255: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 256-256: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 257-257: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 258-258: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 259-259: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 260-260: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 261-261: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 262-262: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 265-265: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 266-266: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 267-267: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 268-268: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 269-269: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 270-270: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 271-271: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 272-272: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 273-273: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 274-274: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 275-275: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 276-276: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 277-277: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 278-278: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 279-279: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
[error] 280-280: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.(lint/correctness/noUnknownProperty)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (20)
packages/nc-gui/assets/style/Inter-new/Inter-Black.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-BlackItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Bold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-BoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraLight.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ExtraLightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Italic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Light.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-LightItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Medium.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-MediumItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Regular.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-SemiBold.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-SemiBoldItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-Thin.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/Inter-ThinItalic.woff2is excluded by!**/*.woff2,!**/*.woff2packages/nc-gui/assets/style/Inter-new/InterVariable-Italic.ttfis excluded by!**/*.ttf,!**/*.ttfpackages/nc-gui/assets/style/Inter-new/InterVariable.ttfis excluded by!**/*.ttf,!**/*.ttf
📒 Files selected for processing (46)
packages/nc-gui/assets/css/global.css(2 hunks)packages/nc-gui/assets/style/Inter-new/inter.css(1 hunks)packages/nc-gui/assets/style/fonts-new.css(1 hunks)packages/nc-gui/assets/style/fonts.css(1 hunks)packages/nc-gui/components/smartsheet/FormulaWrapperCell.vue(1 hunks)packages/nc-gui/components/smartsheet/column/FormulaInputHelper.vue(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts(5 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts(2 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts(4 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/cells/index.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts(30 hunks)packages/nc-gui/components/smartsheet/grid/canvas/index.vue(3 hunks)packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts(1 hunks)packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts(10 hunks)packages/nc-gui/nuxt.config.ts(2 hunks)packages/nc-gui/windi.config.ts(2 hunks)packages/nocodb/src/services/mail/templates/components/RootWrapper.tsx(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- packages/nc-gui/components/smartsheet/column/FormulaInputHelper.vue
- packages/nc-gui/components/smartsheet/FormulaWrapperCell.vue
- packages/nc-gui/components/smartsheet/grid/canvas/loaders/ImageLoader.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/HasMany.ts
- packages/nc-gui/nuxt.config.ts
🚧 Files skipped from review as they are similar to previous changes (40)
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Decimal.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Number.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LTAR/ManyToMany.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Json.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Duration.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Null.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Year.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleLineText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Rating.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Links.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/User.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/GeoData.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/AILongText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Currency.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Url.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/MultiSelect.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/SingleSelect.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/DateTime.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/PhoneNumber.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/index.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/GenericReadonlyRenderer.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Formula.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Time.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/QRCode.ts
- packages/nocodb/src/services/mail/templates/components/RootWrapper.tsx
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Percent.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Attachment.ts
- packages/nc-gui/assets/css/global.css
- packages/nc-gui/components/smartsheet/grid/canvas/cells/LongText.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Button.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Date.ts
- packages/nc-gui/components/smartsheet/grid/canvas/composables/useCanvasRender.ts
- packages/nc-gui/assets/style/fonts.css
- packages/nc-gui/components/smartsheet/grid/canvas/index.vue
- packages/nc-gui/components/smartsheet/grid/canvas/utils/canvas.ts
- packages/nc-gui/components/smartsheet/grid/canvas/cells/Email.ts
- packages/nc-gui/assets/style/fonts-new.css
- packages/nc-gui/windi.config.ts
🧰 Additional context used
🧠 Learnings (1)
packages/nc-gui/assets/style/Inter-new/inter.css (2)
Learnt from: rameshmane7218
PR: nocodb/nocodb#11259
File: packages/nc-gui/assets/style/Inter-new/inter.css:58-71
Timestamp: 2025-05-01T07:00:31.875Z
Learning: In the Inter font implementation in NocoDB, weight 500 intentionally uses Regular files (weight 400), weight 600 uses Medium files, weight 800 uses Bold files, etc. This weight remapping is deliberate to ensure visual consistency during the transition from Manrope to Inter fonts, since Inter naturally appears bolder than Manrope at equivalent weights.
Learnt from: rameshmane7218
PR: nocodb/nocodb#11259
File: packages/nc-gui/assets/style/Inter-new/inter.css:0-0
Timestamp: 2025-05-01T07:00:07.284Z
Learning: In the NocoDB project, the Inter font weights are intentionally mapped differently than standard (using Medium files for weight 600, Bold for weight 800, etc.) to maintain visual consistency with the previous Manrope font, as Inter's natural weights appear bolder than Manrope's equivalent weights.
🪛 Biome (1.9.4)
packages/nc-gui/assets/style/Inter-new/inter.css
[error] 237-237: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 238-238: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 239-239: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 240-240: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 241-241: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 242-242: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 243-243: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 244-244: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 245-245: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 246-246: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 247-247: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 248-248: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 249-249: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 250-250: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 251-251: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 252-252: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 253-253: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 254-254: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 255-255: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 256-256: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 257-257: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 258-258: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 259-259: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 260-260: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 261-261: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 262-262: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 265-265: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 266-266: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 267-267: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 268-268: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 269-269: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 270-270: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 271-271: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 272-272: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 273-273: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 274-274: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 275-275: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 276-276: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 277-277: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 278-278: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 279-279: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 280-280: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: release-docker / buildx
- GitHub Check: unit-tests-pg
- GitHub Check: unit-tests
🔇 Additional comments (2)
packages/nc-gui/assets/style/Inter-new/inter.css (2)
228-232: Global fallback for OpenType features is correctly applied.
Settingfont-feature-settingson thehtmlelement ensures all browsers pick up your character-variant defaults before the@font-feature-valuesoverrides.
284-289: Good use of numeric variants for form elements.
Applyingfont-variant-numeric: tabular-numsto inputs, textareas, selects, and buttons ensures aligned figures in forms.
56b3fe7 to
eac1b1c
Compare
Change Summary
Provide summary of changes with issue number if any.
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of