8000 fix: Handle rendering of Lookup to HM/MM column in grid by pranavxc · Pull Request #10738 · nocodb/nocodb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Handle rendering of Lookup to HM/MM column in grid #10738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 6, 2025
Merged

fix: Handle rendering of Lookup to HM/MM column in grid #10738

merged 4 commits into from
Mar 6, 2025

Conversation

pranavxc
Copy link
Member
@pranavxc pranavxc commented Mar 6, 2025

Change Summary

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@pranavxc pranavxc requested a review from rameshmane7218 March 6, 2025 12:17
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Mar 6, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

This pull request enhances the handling of lookup columns in the Lookup.ts file by introducing a new variable for related table metadata and updating import statements. It implements logic to fetch metadata specifically for lookup columns of type LinkToAnotherRecord and modifies the rendering logic to account for various relationship types. A minor formatting change was also made in the Plain.ts file by removing a blank line.

Changes

File Change Summary
packages/nc-gui/.../cells/Lookup.ts Updated import statements; added lkRelatedTableMeta to store related table metadata; added logic to fetch metadata for lookup columns of type LinkToAnotherRecord; modified lookupRenderer to check for relationship types (HAS_MANY/MANY_TO_MANY) using isLinksOrLTAR.
packages/nc-gui/.../cells/Plain.ts Removed a redundant blank line in the PlainCellRenderer render method, affecting only code formatting.
packages/nc-gui/.../utils/cell.ts Updated renderAsCellLookupOrLtarValue array to include UITypes.LinkToAnotherRecord and UITypes.Links, expanding the types of UI elements that can be rendered.
packages/nc-gui/.../index.vue Introduced new CSS rules for .nc-virtual-cell-lookup class to manage overflow behavior for elements containing .nc-virtual-cell-linktoanotherrecord or .nc-virtual-cell-links.

Possibly related PRs

Suggested labels

🐛 Type: Bug, 🍰 Scope : Column, size:M, lgtm

Suggested reviewers

  • mertmit
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec013cb and 72fe3c9.

📒 Files selected for processing (4)
  • packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts (2 hunks)
  • packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts (0 hunks)
  • packages/nc-gui/components/smartsheet/grid/canvas/index.vue (1 hunks)
  • packages/nc-gui/components/smartsheet/grid/canvas/utils/cell.ts (1 hunks)
💤 Files with no reviewable changes (1)
  • packages/nc-gui/components/smartsheet/grid/canvas/cells/Plain.ts
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/nc-gui/components/smartsheet/grid/canvas/utils/cell.ts
  • packages/nc-gui/components/smartsheet/grid/canvas/cells/Lookup.ts
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: pre-build-for-playwright / playwright
  • GitHub Check: unit-tests-pg
  • GitHub Check: unit-tests
  • GitHub Check: release-docker / buildx
🔇 Additional comments (1)
packages/nc-gui/components/smartsheet/grid/canvas/index.vue (1)

2020-2023: Simple styling fix to prevent content overflow.

The changes add CSS rules that apply !overflow-hidden to lookup cells containing link-to-another-record or links elements, preventing their content from overflowing the cell boundaries. This directly addresses the PR objective of fixing rendering issues with lookup columns in grid view for HM/MM (has-many/many-to-many) relationships.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Mar 6, 2025 •
edited
Loading

Uffizzi Preview deployment-61611 was deleted.

@o1lab o1lab force-pushed the nc-fix/10710-link-in-lookup branch 2 times, most recently from 2981b27 to ec013cb Compare March 6, 2025 13:03
@o1lab o1lab 8000 force-pushed the nc-fix/10710-link-in-lookup branch from ec013cb to 72fe3c9 Compare March 6, 2025 13:14
@rameshmane7218 rameshmane7218 merged commit 626b2ba into develop Mar 6, 2025
22 checks passed
@rameshmane7218 rameshmane7218 deleted the nc-fix/10710-link-in-lookup branch March 6, 2025 14:24
This was referenced Mar 7, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rameshmane7218 rameshmane7218 rameshmane7218 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug: if i make a lookup column where the "lookup field" is a link, it doesn't show in the grid view
2 participants
@pranavxc @rameshmane7218
0