fix(nc-gui): hide `uncategorized` stack if grouping field is required field #9934

rameshmane7218 · 2024-12-02T10:41:57Z

Change Summary

ref: 🐛 Bug: Kanban shows 'Uncategorized' even on non-null enums #7537

Change type

feat: (new feature for the user, not a new feature for build script)
fix: (bug fix for the user, not a fix to a build script)
docs: (changes to the documentation)
style: (formatting, missing semi colons, etc; no production code change)
refactor: (refactoring production code, eg. renaming a variable)
test: (adding missing tests, refactoring tests; no production code change)
chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

coderabbitai · 2024-12-02T10:42:06Z

📝 Walkthrough

Walkthrough

The pull request introduces enhancements to the Kanban.vue component and the useKanbanViewStore.ts composable. Key changes include the addition of a computed property for determining the necessity of a grouping field column, updates to stack visibility logic, and improved error handling in the attachments function. The uncategorizedStackId constant is introduced for better maintainability and is now exported for broader use. Overall, these modifications refine component functionality, control flow, and error management.

Changes

File Path	Change Summary
`packages/nc-gui/components/smartsheet/Kanban.vue`	- Added computed property `isRequiredGroupingFieldColumn` for stack visibility control. - Exported `uncategorizedStackId` for external use. - Modified `attachments` function for better error handling. - Adjusted `expandForm` and stack handling functions to improve control flow.
`packages/nc-gui/composables/useKanbanViewStore.ts`	- Introduced constant `uncategorizedStackId` for filtering logic. - Updated `loadKanbanMeta` to use `uncategorizedStackId` instead of a hardcoded string. - Added `uncategorizedStackId` to return object of `useInjectionState`.

Possibly related PRs

Nc fix: kanban view issues #9649: This PR addresses issues related to the kanban view, specifically enhancing the handling of kanban view metadata, which is directly related to the changes made in the Kanban.vue component regarding stack visibility and the uncategorizedStackId.
fix(nc-gui): add new row btn width issue #8989: Although primarily focused on styling, this PR involves the Table.vue component, which may interact with the kanban view's data representation, potentially linking it to the changes in stack handling in the main PR.
fix(nc-gui): show mfe save changes field error #9535: This PR modifies the Fields.vue component, which may relate to the overall functionality of forms and fields in the kanban view context, especially regarding error handling and user feedback, similar to the changes in Kanban.vue.
Nc fix(nc-gui): MFE show newly added column in same view and hide it in other views #9561: This PR modifies the Fields.vue component to manage column visibility in the MFE, which may relate to the visibility logic introduced in the main PR for kanban stacks.
fix(nc-gui): form view elements over the attachment/pdf viewer #9867: This PR addresses UI issues in the form view, which may indirectly relate to the overall user interface improvements and control flow enhancements made in the main PR.

Suggested labels

size:XS, lgtm

Suggested reviewers

dstala
pranavxc

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between ef3de8c and 4856677.

📒 Files selected for processing (2)

packages/nc-gui/components/smartsheet/Kanban.vue (3 hunks)
packages/nc-gui/composables/useKanbanViewStore.ts (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/nc-gui/composables/useKanbanViewStore.ts

🔇 Additional comments (3)

packages/nc-gui/components/smartsheet/Kanban.vue (3)

72-72: LGTM: Clean store integration

The addition of uncategorizedStackId to the destructured imports is clean and follows the component's existing patterns.

112-114: LGTM: Well-implemented computed property

The computed property is well-named and correctly implements the required field check. The double negation ensures a boolean return value.

504-506: LGTM: Stack visibility logic correctly implemented

The stack visibility logic correctly combines both conditions:

Hiding empty stacks (existing behavior)
Hiding the uncategorized stack when the grouping field is required (new behavior)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

o1lab · 2024-12-02T10:42:32Z

test ccomment

coderabbitai

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

packages/nc-gui/components/smartsheet/Kanban.vue (1)
112-114: Typo in variable name 'isRequiedGroupingFieldColumn'

The variable name isRequiedGroupingFieldColumn contains a typo. It should be isRequiredGroupingFieldColumn to reflect the correct spelling of "required" and maintain code readability.

Apply this diff to correct the typo:
-const isRequiedGroupingFieldColumn = computed(() => {
+const isRequiredGroupingFieldColumn = computed(() => {
Ensure that all references to this variable are updated accordingly.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between e94dc30 and ef3de8c.

📒 Files selected for processing (2)

packages/nc-gui/components/smartsheet/Kanban.vue (3 hunks)
packages/nc-gui/composables/useKanbanViewStore.ts (4 hunks)

🔇 Additional comments (3)

packages/nc-gui/composables/useKanbanViewStore.ts (3)

18-19: Introduction of 'uncategorizedStackId' constant

Defining uncategorizedStackId as a constant improves code maintainability by centralizing its value.

260-262: Correctly filtering out 'uncategorizedStackId'

The filtering logic correctly excludes uncategorizedStackId when updating stack metadata, ensuring proper handling of uncategorized stacks.

726-726: Exporting 'uncategorizedStackId'

Exporting uncategorizedStackId allows it to be utilized in other modules, promoting code reuse and maintainability.

packages/nc-gui/components/smartsheet/Kanban.vue

github-actions · 2024-12-02T10:53:08Z

Uffizzi Preview deployment-58703 was deleted.

… field

rameshmane7218 requested a review from dstala December 2, 2024 10:41

rameshmane7218 self-assigned this Dec 2, 2024

dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 2, 2024

dosubot bot added 🐛 Type: Bug Something is broken or incorrect unexpectedly. 👓 Scope : View Related to views labels Dec 2, 2024

coderabbitai bot reviewed Dec 2, 2024

View reviewed changes

packages/nc-gui/components/smartsheet/Kanban.vue Outdated Show resolved Hide resolved

rameshmane7218 added 2 commits December 2, 2024 10:55

fix(nc-gui): hide uncategorized stack if grouping field is required…

a716218

… field

fix(nc-gui): typo error

4856677

o1lab force-pushed the nc-fix/kanban-stack branch from ef3de8c to 4856677 Compare December 2, 2024 10:55

dstala approved these changes Dec 3, 2024

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 3, 2024

dstala merged commit 7b43411 into develop Dec 3, 2024
19 of 22 checks passed

dstala deleted the nc-fix/kanban-stack branch December 3, 2024 05:37

coderabbitai bot mentioned this pull request Feb 24, 2025

fix(nc-gui): Kanban stacks are expandable in Locked view mode #10604

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(nc-gui): hide `uncategorized` stack if grouping field is required field #9934

fix(nc-gui): hide `uncategorized` stack if grouping field is required field #9934

Uh oh!

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix(nc-gui): hide uncategorized stack if grouping field is required field #9934

fix(nc-gui): hide uncategorized stack if grouping field is required field #9934

Uh oh!

Conversation

Change Summary

Change type

Test/ Verification

Additional information / screenshots (optional)

Uh oh!

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix(nc-gui): hide `uncategorized` stack if grouping field is required field #9934

fix(nc-gui): hide `uncategorized` stack if grouping field is required field #9934

CodeRabbit Configuration File (`.coderabbit.yaml`)