8000 Nc fix/dev warnings by rameshmane7218 · Pull Request #9541 · nocodb/nocodb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Nc fix/dev warnings #9541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Nc fix/dev warnings #9541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a01582
fix(nc-gui): div cannot be child of table
rameshmane7218 Sep 24, 2024
137c2f2
fix(nc-gui): div cannot be child of tr
rameshmane7218 Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions packages/nc-gui/components/dashboard/settings/app-store/AppInstall.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,17 @@ onMounted(async () => {
</tr>
</tbody>

<tr>
<td :colspan="plugin.formDetails.items.length" class="text-center">
<a-button type="default" class="!bg-gray-100 rounded-md border-none mr-1" @click="addSetting">
<template #icon>
<component :is="iconMap.plus" class="flex mx-auto" />
</template>
</a-button>
</td>
</tr>
<tfoot>
<tr>
<td :colspan="plugin.formDetails.items.length" class="text-center">
<a-button type="default" class="!bg-gray-100 rounded-md border-none mr-1" @click="addSetting">
<template #icon>
<component :is="iconMap.plus" class="flex mx-auto" />
</template>
</a-button>
</td>
</tr>
</tfoot>
</table>
</div>

Expand Down
22 changes: 11 additions & 11 deletions packages/nc-gui/components/smartsheet/grid/Table.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2213,8 +2213,8 @@ onKeyStroke('ArrowDown', onDown)
@mouseup.stop
@click="addEmptyRow()"
>
<div
class="h-8 border-b-1 border-gray-100 bg-white group-hover:bg-gray-50 absolute left-0 bottom-0 px-2 sticky z-40 w-full flex items-center text-gray-500"
<td
class="nc-grid-add-new-cell-item h-8 border-b-1 border-gray-100 bg-white group-hover:bg-gray-50 absolute left-0 bottom-0 px-2 sticky z-40 w-full flex items-center text-gray-500"
:style="{
left: `-${leftOffset}px`,
}"
Expand All @@ -2224,7 +2224,7 @@ onKeyStroke('ArrowDown', onDown)
v-if="!isViewColumnsLoading"
class="text-pint-500 text-base ml-2 mt-0 text-gray-600 group-hover:text-black"
/>
</div>
</td>
<td class="!border-gray-100" :colspan="visibleColLength"></td>
</tr>
</tbody>
Expand Down Expand Up @@ -2595,7 +2595,7 @@ onKeyStroke('ArrowDown', onDown)
@apply text-black !bg-gray-50;
}

td,
td:not(.nc-grid-add-new-cell-item),
th {
@apply border-gray-100 border-solid border-r bg-gray-100 p-0;
min-height: 32px !important;
Expand All @@ -2620,11 +2620,11 @@ onKeyStroke('ArrowDown', onDown)
@apply !border-b-1;
}

td {
td:not(.nc-grid-add-new-cell-item) {
@apply bg-white border-b;
}

td:not(:first-child) {
td:not(:first-child):not(.nc-grid-add-new-cell-item) {
@apply px-3;

&.align-top {
Expand Down Expand Up @@ -2742,7 +2742,7 @@ onKeyStroke('ArrowDown', onDown)
border-spacing: 0;
}

td {
td:not(.nc-grid-add-new-cell-item) {
text-overflow: ellipsis;
}

Expand Down Expand Up @@ -2798,7 +2798,7 @@ onKeyStroke('ArrowDown', onDown)
z-index: 5;
}

tbody td:nth-child(1) {
tbody td:not(.nc-grid-add-new-cell-item):nth-child(1) {
position: sticky !important;
left: 0;
z-index: 4;
Expand Down Expand Up @@ -2827,7 +2827,7 @@ onKeyStroke('ArrowDown', onDown)
@apply border-r-1 !border-r-gray-50;
}

tbody td:nth-child(2) {
tbody td:not(.nc-grid-add-new-cell-item):nth-child(2) {
@apply border-r-1 !border-r-gray-50;
}
}
Expand Down Expand Up @@ -2887,7 +2887,7 @@ onKeyStroke('ArrowDown', onDown)

&:not(.selected-row):has(+ .selected-row) {
td.nc-grid-cell:not(.active),
td:nth-child(2):not(.active) {
td:nth-child(2):not(.active):not(.nc-grid-add-new-cell-item) {
@apply border-b-gray-200;
}
}
Expand All @@ -2896,7 +2896,7 @@ onKeyStroke('ArrowDown', onDown)
&:not(.mouse-down):has(+ :hover) {
&:not(.selected-row) {
td.nc-grid-cell:not(.active),
td:nth-child(2):not(.active) {
td:nth-child(2):not(.active):not(.nc-grid-add-new-cell-item) {
@apply border-b-gray-200;
}
}
Expand Down
Loading
0