8000 fix: handle missing col options for button by mertmit · Pull Request #9469 · nocodb/nocodb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: handle missing col options for button #9469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: handle missing col options for button #9469

merged 1 commit into from
Sep 11, 2024

Conversation

mertmit
Copy link
Member
@mertmit mertmit commented Sep 11, 2024

Change Summary

  • Refactor required message
  • Return default col options if missing (AT Import includes those without colOptions instead of having a migration lets support this, moving forward we can consider if we want to avoid creating them altogether)

Change type

  • fix: (bug fix for the user, not a fix to a build script)

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 11, 2024
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Sep 11, 2024 •
edited
Loading
Walkthrough

Walkthrough

The pull request introduces modifications to the ButtonOptions component in a Vue.js application and the Column class in the Nocodb model. The ButtonOptions component now includes a validate property to enhance validation logic, particularly for URL buttons, with clearer error messages. Additionally, it ensures that the formula_raw state is managed properly. In the Column class, a default object is assigned to button configurations when the result from the ButtonColumn.read method is falsy, ensuring robustness in button handling.

Changes

File Path Change Summary
packages/nc-gui/components/smartsheet/column/ButtonOptions.vue Added validate property to useColumnCreateStoreOrThrow(), updated error message for URL buttons, and ensured formula_raw is set to an empty string when not present.
packages/nocodb/src/models/Column.ts Added default object assignment for button configurations in ButtonColumn.read method when result is falsy.
Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e34cd9b and 6e87508.

Files selected for processing (2)
  • packages/nc-gui/components/smartsheet/column/ButtonOptions.vue (3 hunks)
  • packages/nocodb/src/models/Column.ts (1 hunks)
Additional comments not posted (3)
packages/nc-gui/components/smartsheet/column/ButtonOptions.vue (2)

29-30: LGTM!

The addition of the validate property to the destructured properties from useColumnCreateStoreOrThrow() is approved. It will likely be used for validation purposes in the component.

195-196: LGTM!

The change to set the default value of vModel.value.formula_raw to an empty string when the condition (column.value?.colOptions as any)?.formula_raw is falsy is approved. This ensures consistent state management and prevents undefined values.

packages/nocodb/src/models/Column.ts (1)

506-517: Approved: Default values for missing button column options.

The changes add robustness by ensuring default values are used when the retrieved button column options are missing. This prevents potential errors that could arise from missing options.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dosubot dosubot bot added the 🐛 Type: Bug Something is broken or incorrect unexpectedly. label Sep 11, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 11, 2024
@DarkPhoenix2704 DarkPhoenix2704 merged commit 98998b7 into develop Sep 11, 2024
23 of 57 checks passed
@DarkPhoenix2704 DarkPhoenix2704 deleted the nc-fix/at-button-ph branch September 11, 2024 15:35
This was referenced Sep 14, 2024
Closed
Merged
This was referenced Dec 4, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkPhoenix2704 DarkPhoenix2704 DarkPhoenix2704 approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. 🐛 Type: Bug Something is broken or incorrect unexpectedly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mertmit @DarkPhoenix2704
0