8000 chore: move sync action after npm release as it pushes some commits by mertmit · Pull Request #8607 · nocodb/nocodb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: move sync action after npm release as it pushes some commits #8607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2024
Merged

chore: move sync action after npm release as it pushes some commits #8607

merged 1 commit into from
May 29, 2024

Conversation

mertmit
Copy link
Member
@mertmit mertmit commented May 29, 2024

Change Summary

  • This step have to run after npm release as it also commits into master

Change type

  • chore: (updating grunt tasks etc; no production code change)

@mertmit
chore: move sync action after npm release as it pushes some commits
c0a9c4e 
Signed-off-by: mertmit <mertmit99@gmail.com>
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 29, 2024 •
edited
Loading
Walkthrough

Walkthrough

The release-nocodb.yml workflow file in the GitHub Actions configuration was updated. The previous sync-to-develop job, which created a pull request to sync changes from the master branch back to the develop branch, was removed and replaced with a new job that performs the same action.

Changes

File Change Summary
.github/workflows/release-nocodb.yml Removed the old sync-to-develop job and added a new sync-to-develop job to create a PR syncing changes from master to develop.

Tip

Early Access Features
  • gpt-4o model for chat

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mertmit mertmit mentioned this pull request May 29, 2024
Merged
coderabbitai[bot]
coderabbitai bot reviewed May 29, 2024
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
.github/workflows/release-nocodb.yml (1)

Line range hint 34-49: Address potential security vulnerability with variable interpolation.

The use of ${{...}} directly in the run: step exposes the workflow to potential security risks, as it could allow an attacker to inject malicious code. To mitigate this, use an intermediate environment variable. Here's how you can adjust it:

- TARGET_TAG=${{github.event.inputs.tag}}
- PREV_TAG=${{github.event.inputs.prev_tag}}
+ env:
+   TARGET_TAG: ${{ github.event.inputs.tag }}
+   PREV_TAG: ${{ github.event.inputs.prev_tag }}
+ run: |
+   TARGET_TAG=${TARGET_TAG}
+   PREV_TAG=${PREV_TAG}

Ensure to use double quotes when referencing these environment variables in the script.

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 58a9a27 and c0a9c4e.
Files selected for processing (1)
  • .github/workflows/release-nocodb.yml (2 hunks)
Additional comments not posted (1)
.github/workflows/release-nocodb.yml (1)

73-77: The placement of the sync-to-develop job after the release-npm job aligns with the PR objectives to ensure synchronization occurs post-release.

@pranavxc pranavxc merged commit 22c3dbc into develop May 29, 2024
1 check passed
@pranavxc pranavxc deleted the chore/fix-sync-action branch May 29, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@pranavxc pranavxc pranavxc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mertmit @pranavxc
0