8000 fix: tweak invite and verify e-mail templates by salim-b · Pull Request #8529 · nocodb/nocodb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: tweak invite and verify e-mail templates #8529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2024
Merged

fix: tweak invite and verify e-mail templates #8529

merged 1 commit into from
May 20, 2024

Conversation

salim-b
Copy link
Contributor
@salim-b salim-b commented May 19, 2024

Change Summary

Just some small rewordings / corrections of the invitation and e-mail verification templates.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Untested.

Additional information / screenshots (optional)

Note that the <%- baseName %> placeholder doesn't work, i.e. results in an empty string in the sent e-mail. Unfortuantely, I dunno how to fix this.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 19, 2024 •
edited
Loading
Walkthrough

Walkthrough

The recent changes in the NocoDB project focus on refining email templates used for user invitations and email verifications. The updates aim to enhance clarity, consistency, and personalization in the messages. This includes rephrasing invitation texts, ensuring consistent use of the term "e-mail," and updating closing salutations to dynamically include the admin's email address for a more personalized touch.

Changes

File Path Change Summary
packages/nocodb/src/controllers/auth/ui/emailTemplates/invite.ts Modified the invitation message to "You have been invited to become" and updated the closing salutation to "Have a nice day,
<%- adminEmail %>."
packages/nocodb/src/controllers/auth/ui/emailTemplates/verify.ts Changed "Please verify your email address" to "Please verify your e-mail address" and updated the closing message to "Thank you and have a nice day, <%- adminEmail %>."
packages/nocodb/src/services/base-users/ui/emailTemplates/invite.ts Refined the invitation message to improve clarity and readability.
packages/nocodb/src/services/base-users/ui/emailTemplates/verify.ts Changed "email" to "e-mail" for consistency and added a personalized sign-off with the admin's email address.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 19, 2024
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 95cd67c and 33312bd.
Files selected for processing (4)
  • packages/nocodb/src/controllers/auth/ui/emailTemplates/invite.ts (2 hunks)
  • packages/nocodb/src/controllers/auth/ui/emailTemplates/verify.ts (2 hunks)
  • packages/nocodb/src/services/base-users/ui/emailTemplates/invite.ts (2 hunks)
  • packages/nocodb/src/services/base-users/ui/emailTemplates/verify.ts (2 hunks)
Files skipped from review due to trivial changes (1)
  • packages/nocodb/src/services/base-users/ui/emailTemplates/verify.ts
Additional comments not posted (6)
packages/nocodb/src/controllers/auth/ui/emailTemplates/verify.ts (2)

135-135: Change from "email" to "e-mail" enhances consistency in terminology.

163-163: Updated closing message improves the tone and politeness of the communication.

packages/nocodb/src/controllers/auth/ui/emailTemplates/invite.ts (2)

135-136: Rephrased invitation message is more formal and appropriate. Ensure that placeholders <%- roles %> and <%- baseName %> are correctly replaced at runtime.

164-164: Updated closing message enhances the friendliness of the email.

packages/nocodb/src/services/base-users/ui/emailTemplates/invite.ts (2)

135-136: Identical changes to the other invite.ts: Rephrased invitation message is appropriate. Verify that placeholders <%- roles %> and <%- baseName %> are correctly replaced.

164-164: Consistent with the other invite.ts: Updated closing message improves the tone of the email.

@dstala dstala merged commit 9ed9ac5 into nocodb:develop May 20, 2024
20 of 23 checks passed
@salim-b
Copy link
Contributor Author
salim-b commented May 20, 2024

@dstala Do you know why the <%- baseName %> placeholder in the e-mail templates doesn't work, i.e. results in an empty string in the sent e-mail?

@salim-b salim-b deleted the invite-tpl branch May 20, 2024 10:35
@coderabbitai coderabbitai bot mentioned this pull request Nov 12, 2024
Merged
1 task
@salim-b salim-b mentioned this pull request Nov 27, 2024
Closed
1 task
@pranavxc pranavxc mentioned this pull request Nov 28, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@dstala dstala dstala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salim-b @dstala
0