fix: Extract primary key value properly when table missing auto-incremented/auto-generated primary key #8480
Conversation
WalkthroughWalkthroughThe changes focus on the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/nocodb/src/db/BaseModelSqlv2.ts (3 hunks)
Additional comments not posted (3)
packages/nocodb/src/db/BaseModelSqlv2.ts (3)
2763-2763: Ensureaiparameter is correctly initialized and passed.Verify that the
aiparameter is correctly initialized and passed to this function. This will ensure that the logic depending onaiworks as expected.
2807-2807: EnsureextractCompositePKfunction signature matches the new call.Verify that the
extractCompositePKfunction signature has been updated to accept theaiparameter. This will ensure that the function call is correct and prevent potential runtime errors.
3274-3282: Ensure correct handling of non-auto-incremented or non-auto-generated primary keys.Verify that the logic correctly handles both single and composite primary keys when they are not auto-incremented or auto-generated. This will ensure that the primary key extraction works as expected in these cases.
Change Summary
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of