8000 Nc fix/column delete bug by pranavxc · Pull Request #8178 · nocodb/nocodb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Nc fix/column delete bug #8178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 4, 2024
Merged

Nc fix/column delete bug #8178

merged 5 commits into from
Apr 4, 2024

Conversation

pranavxc
Copy link
Member
@pranavxc pranavxc commented Apr 4, 2024 •
edited by coderabbitai bot
Loading

Change Summary

Provide summary of changes with issue number if any.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

Summary by CodeRabbit

  • New Features

    • Introduced input sanitization for URL fields to enhance data validation and formatting.

  • Improvements

    • Improved data reloading behavior in the toolbar's column filter by specifying data offset.
    • Streamlined handling of various view columns in the database, focusing on efficient data insertion and cache management.

  • Refactor

    • Simplified code by removing unnecessary cache setting operations across different view models.
    • Adjusted 8000 data insertion and caching logic for a more consistent approach in handling metadata.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Apr 4, 2024 •
edited
Loading
Walkthrough

Walkthrough

The updates focus on enhancing data handling and UI elements across various components and models within the project. Key improvements include the introduction of a new function for URL validation, adjustments in data reloading mechanisms, and a series of refinements in handling view columns across different models. These changes aim to increase the robustness of URL inputs, optimize data reloading, and streamline the management of view columns by refining data insertion and cache management strategies.

Changes

File Path Change Summary
.../cell/Url.vue
.../components/virtual-cell/components/UnLinkedItems.vue		 Introduced trim function for input sanitization, updated import block, spacing, and pagination behavior.
.../composables/useLTARStore.ts Adjusted offset calculation and refined function formatting.
.../models/Column.ts
.../services/views.service.ts		 Refactored Column.ts to handle different view column types with metadata operations. Added model existence check in views.service.ts before further processing.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pranavxc pranavxc requested a review from mertmit April 4, 2024 08:57
wingkwong
wingkwong reviewed Apr 4, 2024
View reviewed changes
coderabbitai[bot]
coderabbitai bot reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between a8a7abb and a367f5d.
Files selected for processing (9)
  • packages/nc-gui/components/cell/Url.vue (2 hunks)
  • packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (1 hunks)
  • packages/nocodb/src/models/CalendarViewColumn.ts (1 hunks)
  • packages/nocodb/src/models/Column.ts (1 hunks)
  • packages/nocodb/src/models/FormViewColumn.ts (1 hunks)
  • packages/nocodb/src/models/GalleryViewColumn.ts (1 hunks)
  • packages/nocodb/src/models/GridViewColumn.ts (1 hunks)
  • packages/nocodb/src/models/KanbanViewColumn.ts (1 hunks)
  • packages/nocodb/src/models/MapViewColumn.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • packages/nocodb/src/models/GridViewColumn.ts
Additional comments not posted (6)
packages/nocodb/src/models/KanbanViewColumn.ts (1)

66-66: Ensure the adjustments in handling fk_column_id and caching logic do not negatively impact other functionalities that may rely on them.

packages/nocodb/src/models/GalleryViewColumn.ts (1)

69-69: Ensure the adjustments in handling fk_column_id and caching logic do not negatively impact other functionalities that may rely on them.

packages/nocodb/src/models/CalendarViewColumn.ts (1)

82-82: Ensure the adjustments in handling fk_column_id and caching logic do not negatively impact other functionalities that may rely on them.

packages/nc-gui/components/cell/Url.vue (1)

50-50: The introduction of trimVal function enhances URL validation by ensuring leading and trailing spaces do not affect the process. Good improvement!

packages/nocodb/src/models/FormViewColumn.ts (1)

95-95: Ensure the adjustments in handling fk_column_id and caching logic do not negatively impact other functionalities that may rely on them.

packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (1)

84-84: Adding an offset: 0 parameter to the reloadDataHook.trigger function call is a good practice for resetting the data view to the beginning when filters are applied, enhancing user experience.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Apr 4, 2024 •
edited
Loading

Uffizzi Preview deployment-49473 was deleted.

coderabbitai[bot]
coderabbitai bot reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between a367f5d and 0f7c2e6.
Files selected for processing (4)
  • packages/nc-gui/components/cell/Url.vue (2 hunks)
  • packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (3 hunks)
  • packages/nc-gui/composables/useLTARStore.ts (2 hunks)
  • packages/nocodb/src/models/Column.ts (1 hunks)
Files skipped from review as they are similar to previous changes (2)
  • packages/nc-gui/components/cell/Url.vue
  • packages/nocodb/src/models/Column.ts
Additional comments not posted (4)
packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (2)

54-54: The addition of a comma after resetChildrenExcludedOffsetCount in the import block is a good practice for maintainability.

265-265: Removing the semicolon after setting childrenExcludedListPagination.page to 1 in the onFilterChange function aligns with common JavaScript style guides.

packages/nc-gui/composables/useLTARStore.ts (2)

194-195: Adjusting the calculation of the offset variable in the loadChildrenExcludedList function improves robustness by ensuring the offset cannot be negative.

554-555: Refining the formatting of the resetChildrenExcludedOffsetCount function enhances readability and consistency in the codebase.

@pranavxc
refactor: avoid duplicate code
fd275a1 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc pranavxc force-pushed the nc-fix/column-delete-bug branch from 0f7c2e6 to fd275a1 Compare April 4, 2024 11:09
coderabbitai[bot]
coderabbitai bot reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between a367f5d and fd275a1.
Files selected for processing (4)
  • packages/nc-gui/components/cell/Url.vue (2 hunks)
  • packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue (3 hunks)
  • packages/nc-gui/composables/useLTARStore.ts (2 hunks)
  • packages/nocodb/src/models/Column.ts (1 hunks)
Files skipped from review as they are similar to previous changes (4)
  • packages/nc-gui/components/cell/Url.vue
  • packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue
  • packages/nc-gui/composables/useLTARStore.ts
  • packages/nocodb/src/models/Column.ts

@pranavxc
fix: typo correction
04330cb 
Signed-off-by: Pranav C <pranavxc@gmail.com>
coderabbitai[bot]
coderabbitai bot reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between fd275a1 and 04330cb.
Files selected for processing (2)
  • packages/nocodb/src/models/Column.ts (1 hunks)
  • packages/nocodb/src/services/views.service.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • packages/nocodb/src/models/Column.ts

@pranavxc pranavxc added 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. and removed 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. labels Apr 4, 2024
@pranavxc pranavxc merged commit e721491 into develop Apr 4, 2024
@pranavxc pranavxc deleted the nc-fix/column-delete-bug branch April 4, 2024 13:38
This was referenced Apr 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wingkwong wingkwong wingkwong left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@mertmit mertmit mertmit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavxc @wingkwong @mertmit
0