8000 Nc fix(nc-gui): prefill currency readonly field ui alignment issue by rameshmane7218 · Pull Request #7978 · nocodb/nocodb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Nc fix(nc-gui): prefill currency readonly field ui alignment issue #7978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2024
Merged

Nc fix(nc-gui): prefill currency readonly field ui alignment issue #7978

merged 1 commit into from
Mar 27, 2024

Conversation

rameshmane7218
Copy link
Member
@rameshmane7218 rameshmane7218 commented Mar 27, 2024 •
edited by coderabbitai bot
Loading

Change Summary

Provide summary of changes with issue number if any.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

Summary by CodeRabbit

  • Bug Fixes
    • Updated visibility conditions and added a disabled state for the currency input field in forms and editable columns, enhancing user interaction and data integrity.

@rameshmane7218 rameshmane7218 requested a review from dstala March 27, 2024 05:20
@rameshmane7218 rameshmane7218 self-assigned this Mar 27, 2024
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Mar 27, 2024 •
edited
Loading
Walkthrough

Walkthrough

The update made to the Currency.vue component involves enhancing the input field's visibility and interaction. Now, the field's visibility is determined not only by previous conditions but also by checking isForm and isEditColumn. Additionally, the input can be disabled based on the readOnly property. This change aims to improve user experience by making the UI more dynamic and responsive to different states, such as form editing or read-only views.

Changes

File Path Change Summary
.../nc-gui/components/cell/Currency.vue Updated input visibility to include isForm and isEditColumn checks; added :disabled attribute based on readOnly.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot]
coderabbitai bot reviewed Mar 27, 2024
View reviewed chang 8000 es
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 1ec1745 and 028c4e7.
Files selected for processing (1)
  • packages/nc-gui/components/cell/Currency.vue (1 hunks)
Additional comments: 1
packages/nc-gui/components/cell/Currency.vue (1)
  • 115-122: The logic for displaying the input field has been updated to include checks for isForm and isEditColumn, and a :disabled attribute has been added based on the readOnly property. This approach effectively addresses the UI alignment issue and enhances the functionality of the currency input field in its read-only state. However, consider adding a brief comment explaining the logic behind the visibility condition for future maintainability.

Additionally, ensure that the readOnly property is consistently updated across different states of the application to avoid any unexpected behavior.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Mar 27, 2024 •
edited
Loading

Uffizzi Preview deployment-48992 was deleted.

@rameshmane7218 rameshmane7218 merged commit ee363f8 into develop Mar 27, 2024
@rameshmane7218 rameshmane7218 deleted the nc-fix/prefix-form branch March 27, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@dstala dstala dstala approved these changes

Assignees

@rameshmane7218 rameshmane7218

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rameshmane7218 @dstala
0