8000 🐛 Bug: email verification not working · Issue #7473 · nocodb/nocodb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🐛 Bug: email verification not working #7473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
asaage opened this issue Jan 21, 2024 · 3 comments · Fixed by #8645
Closed
1 task done

🐛 Bug: email verification not working #7473

asaage opened this issue Jan 21, 2024 · 3 comments · Fixed by #8645

Comments

@asaage
Copy link
asaage commented Jan 21, 2024

Please confirm if bug report does NOT exists already ?

  • I confirm there is no existing issue for this

Steps to reproduce ?

When inviting new users to a workspace the verify Email is being sent
but the link responds 404 {"msg":"Cannot GET /email/verify/email_verification_token"}

Desired Behavior

should verify sucessfully...
On the other hand - in case of invitation i would prefer to skip this entirely and go on with setting a password for the new user.

Project Details

Node: v18.18.2
Arch: x64
Platform: linux
Docker: true
RootDB: mysql2
PackageVersion: 0.204.0

Attachments

No response
@opokhvalit
Copy link
opokhvalit commented Jan 23, 2024 •
edited
Loading

I can confirm that behavior. NocoDB sent incorrect invite and verification links.
For invite I've got link like:
//dashboard#/signup/<ID>
but correct link must looks like:
/dashboard/#/signup/<ID>

The similar thing for email verification link, I've got
//email/verify/<ID>
but proper link must looks like
/#/email/verify/<ID>

Node: v18.18.2
Arch: x64
Platform: linux
Docker: true
RootDB: mysql2
PackageVersion: 0.204.0

@opokhvalit
Copy link

I fixed partially my issues

  1. for NC_PUBLIC_URL we should NOT put trailing slash
  2. for NC_DASHBOARD_URL we must put trailing slash
    So, that will resolve invite link issues

Email verification link issue is still present. I really didn't get nesessity of email verification and didn't find where that confirmation marked as done

@SteffeyDev
Copy link

I'm seeing same issue, when user tries to verify email, they are redirected to a page that shows {"msg":"Cannot GET /email/verify/602dc059-66c3-45d6-8b96-f0261ccbc259"}. The link appears formatted correctly. I checked the DB and the 602dc059-66c3-45d6-8b96-f0261ccbc259 does match their user in the email_verification_token column in the nc_users_v2 table. Using docker :latest.

Full error output:

[Nest] 11  - 02/19/2024, 7:36:39 PM   DEBUG [GlobalExceptionFilter] NotFoundException: Cannot GET /email/verify/602dc059-66c3-45d6-8b96-f0261ccbc259
    at callback (/usr/src/app/node_modules/@nestjs/core/router/routes-resolver.js:77:19)
    at /usr/src/app/node_modules/@nestjs/core/router/router-proxy.js:9:23
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/usr/src/app/node_modules/express/lib/router/index.js:328:13)
    at /usr/src/app/node_modules/express/lib/router/index.js:286:9
    at Function.process_params (/usr/src/app/node_modules/express/lib/router/index.js:346:12)
    at next (/usr/src/app/node_modules/express/lib/router/index.js:280:10)
    at next (/usr/src/app/node_modules/express/lib/router/route.js:136:14)
    at next (/usr/src/app/node_modules/express/lib/router/route.js:140:7)
    at next (/usr/src/app/node_modules/express/lib/router/route.js:140:7)

@salim-b salim-b mentioned this issue Apr 2, 2024
Closed
1 task
salim-b added a commit to salim-b/nocodb that referenced this issue Jun 4, 2024
@salim-b
fix: e-mail verification endpoint path
f3a3f58 
fixes nocodb#7241 nocodb#7473
@salim-b salim-b mentioned this issue Jun 4, 2024
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from 🏌️ Open to ✅ Closed in 🚀 NocoDB: Issue Board Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: e-mail verification endpoint path salim-b/nocodb
3 participants
@asaage @SteffeyDev @opokhvalit
0