batchnorm and norm_fiber_inplace renaming #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Muxas
reviewed
Nov 27, 2024
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Add check of src2 shape and basetile_shape. It must match shapes of dst
| if(init_first) | ||
| { | ||
| starpu::norm_fiber::submit<T>(m, n, k, batch, alpha, | ||
| src_tile_handle, beta, dst_tile_handle); | ||
| src1_tile_handle, beta, src2_tile_handle, dst_tile_handle); | ||
| } | ||
| else |
There was a problem hiding this comment.
this is totally incorrect. When you do initialization, you do dst[l]=alpha*src1[0,l,0]+beta*src2[l]. But then you update resulting dst inplace: dst[l]=alpha*src1[i,l,j]+dst[l]. Instead of norm_fiber an inplace version shall be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in Progress