8000 types: mark `$global` optional for `NitroRouteMeta` by pradel · Pull Request #3174 · nitrojs/nitro · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

types: mark $global optional for NitroRouteMeta #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

types: mark $global optional for NitroRouteMeta #3174

merged 1 commit into from
Mar 7, 2025

Conversation

pradel
Copy link
Contributor
@pradel pradel commented Mar 7, 2025

🔗 Linked issue

#3173

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Make $global optional for openAPI route meta so apps upgrading from niro 2.10 to 2.11 don't get typecheck to fail.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pradel pradel requested a review from pi0 as a code owner March 7, 2025 08:24
@pradel pradel mentioned this pull request Mar 7, 2025
Merged
pi0
pi0 approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member
@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnx!

@pi0 pi0 changed the title fix: make $global optional for openAPI route meta types: mark $global optional for NitroRouteMeta Mar 7, 2025
@pi0 pi0 merged commit 7cbf0b2 into nitrojs:v2 Mar 7, 2025
4 checks passed
@pradel pradel deleted the feat/openapi-route-meta-global-optional branch March 7, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pradel @pi0
0