8000 feat(aws): add custom domains for pulumi and terraform websites by HomelessDinosaur · Pull Request #784 · nitrictech/nitric · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(aws): add custom domains for pulumi and terraform websites #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 8, 2025
Merged

feat(aws): add custom domains for pulumi and terraform websites #784

merged 6 commits into from
May 8, 2025

Conversation

HomelessDinosaur
Copy link
Member

Relies on base: #763 before merging.

@HomelessDinosaur HomelessDinosaur marked this pull request as draft April 11, 2025 06:28
@HomelessDinosaur HomelessDinosaur changed the title Feat/cdn domains feat: add custom domains for pulumi and terraform websites Apr 11, 2025
@davemooreuws
8000 Copy link
Member

requires a rebase @HomelessDinosaur

@davemooreuws davemooreuws self-requested a review April 15, 2025 06:16
@davemooreuws davemooreuws self-assigned this Apr 15, 2025
@HomelessDinosaur HomelessDinosaur marked this pull request as ready for review May 1, 2025 03:40
@davemooreuws davemooreuws changed the title feat: add custom domains for pulumi and terraform websites feat(aws): add custom domains for pulumi and terraform websites May 1, 2025
@HomelessDinosaur HomelessDinosaur force-pushed the feat/cdn-domains branch 2 times, most recently from b5202d9 to e43c2e8 Compare May 1, 2025 06:17
@davemooreuws
Copy link
Member

needs a rebase again @HomelessDinosaur

@codecov Codecov
Copy link
codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.83%. Comparing base (4c9c1af) to head (7926c53).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #784   +/-   ##
=======================================
  Coverage   48.83%   48.83%           
=======================================
  Files          28       28           
  Lines        3551     3551           
=======================================
  Hits         1734     1734           
  Misses       1698     1698           
  Partials      119      119
Flag Coverage Δ
aws 44.89% <ø> (ø)
azure 53.54% <ø> (ø)
core 60.76% <ø> (ø)
gcp 47.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jyecusch jyecusch requested a review from davemooreuws May 8, 2025 22:55
@jyecusch jyecusch merged commit 64e9d90 into nitrictech:main May 8, 2025
2 checks passed
@nitric-bot
Copy link

🎉 This PR is included in version 1.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyecusch jyecusch jyecusch approved these changes

@tjholm tjholm Awaiting requested review from tjholm tjholm is a code owner

@davemooreuws davemooreuws Awaiting requested review from davemooreuws

Assignees

@jyecusch jyecusch

@davemooreuws davemooreuws

@tjholm tjholm

@HomelessDinosaur HomelessDinosaur

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HomelessDinosaur @davemooreuws @nitric-bot @jyecusch @tjholm
0