[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RF: Drop various remaining compatibilities for Python < 3.5 #2831

Merged
merged 4 commits into from
Jan 1, 2019
Merged

RF: Drop various remaining compatibilities for Python < 3.5 #2831

merged 4 commits into from
Jan 1, 2019

Conversation

effigies
Copy link
Member

Summary

In merging master into dev/2.0, I saw a Python >= 3.2 check, indicating a less-than-thorough purge of all obsolete version checks. Here I grepped for sys.version and removed any checks that no longer apply for Python < 3.5. (I think < 3.4.1 is the actual highest check, so we're not in the range of distinguishing 3.5 and 3.6.)

The main thing to-do is to change to_str() to str() everywhere, and remove that function fully, but I want to get tests running to make sure I'm not breaking anything.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies effigies added this to the Nipype 2.0 milestone Dec 17, 2018
@codecov-io
Copy link
codecov-io commented Dec 17, 2018 •
edited
Loading

Codecov Report

Merging #2831 into dev/2.0 will increase coverage by 0.44%.
The diff coverage is 86.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           dev/2.0    #2831      +/-   ##
===========================================
+ Coverage    66.67%   67.11%   +0.44%     
===========================================
  Files          338      338              
  Lines        42879    42798      -81     
  Branches      5363     5338      -25     
===========================================
+ Hits         28588    28726     +138     
+ Misses       13566    13378     -188     
+ Partials       725      694      -31
Flag Coverage Δ
#smoketests 49.95% <75.86%> (+1.17%) ⬆️
#unittests 64.5% <86.66%> (+0.08%) ⬆️
Impacted Files Coverage Δ
nipype/info.py 93.75% <ø> (+1.21%) ⬆️
nipype/sphinxext/plot_workflow.py 13.79% <0%> (+0.11%) ⬆️
nipype/pipeline/plugins/tools.py 84.5% <100%> (ø) ⬆️
nipype/utils/profiler.py 18.49% <100%> (+0.47%) ⬆️
nipype/interfaces/base/specs.py 93.01% <100%> (ø) ⬆️
nipype/pipeline/engine/utils.py 81.93% <100%> (+3.45%) ⬆️
nipype/utils/filemanip.py 78.79% <100%> (+8.5%) ⬆️
nipype/interfaces/base/support.py 79.41% <100%> (ø) ⬆️
nipype/pipeline/engine/nodes.py 84.42% <75%> (ø) ⬆️
nipype/pipeline/engine/workflows.py 78.81% <81.81%> (+0.33%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e057971...dc89681. Read the comment docs.

@effigies effigies merged commit 80ed64d into nipy:dev/2.0 Jan 1, 2019
@effigies effigies deleted the dev/2/min_version branch January 1, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
nipype 2.0
Projects
None yet
Milestone
Nipype 2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@effigies @codecov-io