8000 add testing with envtest by tommyknows · Pull Request #3 · ninech/relokator · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add testing with envtest #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2020
Merged

add testing with envtest #3

merged 1 commit into from
Jul 9, 2020

Conversation

tommyknows
Copy link
Contributor

This commit adds testing! 🥳

It uses the envtest package (which means that etcd and kube-apiserver
must be installed) and wraps the usual phases with testing. This way,
correct behaviour of each phase can be ensured.

Signed-off-by: Ramon Rüttimann ramon@nine.ch

ctrox
ctrox reviewed Jul 8, 2020
View reviewed changes
Copy link
Contributor
@ctrox ctrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite complex testing all of this. Especially the addAssertions bit, but looks really solid in general!

@tommyknows
Copy link
Contributor Author
tommyknows commented Jul 9, 2020 •
edited
Loading

Quite complex testing all of this. Especially the addAssertions bit, but looks really solid in general!

Kinda agree, that's why there's a rather lengthy comment on that function. And I don't think it's a lot more complex than the idea (e.g. the complexity between theory and practice is roughly equal).

But I'm probably biased here because I wrote it, so:
Do you think it needs a better description? Or could be simplified somehow?

@ctrox
Copy link
Contributor
ctrox commented Jul 9, 2020

Quite complex testing all of this. Especially the addAssertions bit, but looks really solid in general!

Kinda agree, that's why there's a rather lengthy comment on that function. And I don't think it's a lot more complex than the idea (e.g. the complexity between theory and practice is roughly equal).

But I'm probably biased here because I wrote it, so:
Do you think it needs a better description? Or could be simplified somehow?

No I think it is fine, just wanted to mention it :) The comment explains it pretty well.

add testing with envtest
62aa2c5 
This commit adds testing! 🥳

It uses the envtest package (which means that etcd and kube-apiserver
must be installed) and wraps the usual phases with testing. This way,
correct behaviour of each phase can be ensured.

Signed-off-by: Ramon Rüttimann <ramon@nine.ch>
@tommyknows
Copy link
Contributor Author

Alright, I fixed the points you mentioned 👍

@tommyknows tommyknows merged commit bdc1c4a into ninech:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrox ctrox ctrox approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommyknows @ctrox
0