Domains section wip #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to change it to draft until it's ready? |
I dont see that option actually |
|
also included some fixes for landing page so it looks decent on mobile on last 2 commits |
added 2 commits
May 2, 2022 23:31
adamazad
requested changes
May 2, 2022
| import { transparentize } from 'polished' | ||
| import styled from 'styled-components' | ||
| import { transparentize } from 'polished'; | ||
| import styled from 'styled-components'; | ||
|
|
||
| export const GovernanceText = styled.span` |
src/pages/Domains/index.tsx
Outdated
Comment on lines
5
to
16
| const arrayOfEnsData = [ | ||
| { | ||
| ensDomain: 'milanrasovic.eth', | ||
| imageUrl: 'https://pbs.twimg.com/profile_images/1511030457093271558/GBHgfEOS_400x400.jpg', | ||
| }, | ||
| { | ||
| ensDomain: 'blue.eth', | ||
| imageUrl: 'https://pbs.twimg.com/profile_images/701077842197618688/6mRqLx_p_400x400.jpg', | ||
| }, | ||
| { ensDomain: 'green.eth', imageUrl: '' }, | ||
| { ensDomain: 'red.eth', imageUrl: '' }, | ||
| ]; |
There was a problem hiding this comment.
These should be moved to mocks fixtures
| <ButtonPrimary> | ||
| <CTAButtonWrapper> | ||
| <CTAButtonLogo /> | ||
| <span>Go to Nimi</span> |
Co-authored-by: Adam Azad <adam@adamazad.com>
Co-authored-by: Adam Azad <adam@adamazad.com>
adamazad
requested changes
May 2, 2022
src/components/EnsNameCard/index.tsx
Outdated
| imageUrl?: string; | ||
| } | ||
|
|
||
| export default function ENSNameCard({ ensDomain, imageUrl }: ENSCardProps) { |
There was a problem hiding this comment.
For sake of convention, let's avoid default exports in this project.
| @@ -0,0 +1,12 @@ | |||
| export const MockENSData = [ | |||
There was a problem hiding this comment.
Nice! If you like, you can move these to the root of the project. It's still fine here.
This was referenced Jul 24, 2022
Closed
8 tasks
Mi-Lan
pushed a commit
that referenced
this pull request
Dec 16, 2022
* Updated Nimi Card dependency. * Removed HashRouter. * Updated routing. * Added redirection to home, removed unused route. * Removed unused code. * Updated providers. * Created React Query provider. * Created Redux provider. * Created Wagmi provider. * Updated index.ts. * Updated providers. * Updated Wagmi provider. * Updated useRainbow hook. * Updated useENSMetadata hook. * Removed broken Fathom functionality. * Created LoggedInWrapper. * Updated App component. * Updated naming. * Added Wagmi dependency. * Updated Wagmi imports as per documentation. * Added missing TS ESlint parser dependency, removed some other deps. * Removed unused dependencies. * Removed unused dependencies. * Removed unused dependencies. * Removed unused dependencies. * Removed unused dependencies. * Added missing dependencies. * Added missing dependency. * Updated package.json. * Updated dependencies. * Added licence field. * Updated useENSMetadata hook. * Updated AppWrapper component. * Updated App component. * Updated pages. * Updated WagmiProvider. * Updated package-lock.json. * Package.json updated. * Updated dependencies. * Added AppWrapper to CreateNimiContainer. * Updated package-lock.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working on domains section and ensNameCard styles only
@adamazad dont look at this code yet I need to tidy it up