Import from Linktree #166
Merged
Import from Linktree #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
added 10 commits
October 4, 2022 17:38
adamazad
reviewed
Nov 28, 2022
Comment on lines
11
to
+14
| if (!process.env.REACT_APP_NIMI_API_BASE_URL) { | ||
| throw new Error('REACT_APP_NIMI_API_BASE_URL is not set.'); | ||
| } else if (!process.env.NODE_ENV || process.env.NODE_ENV === 'development') { | ||
| return process.env.REACT_APP_NIMI_API_DEV_BASE_URL; |
There was a problem hiding this comment.
It's good to require the presence of EITHER development or production.
There was a problem hiding this comment.
what do you mean by this its? Thats what it should do it just a check when to use development vs production url...
|
Someone is attempting to deploy this commit to the nimi-app Team on Vercel. To accomplish this, the commit author's email address needs to be associated with a GitHub account. Learn more about how to change the commit author information. |
adamazad
reviewed
Dec 5, 2022
adamazad
approved these changes
Dec 6, 2022
| }) | ||
| .then(({ data }) => { | ||
| const mappedLinks = data.data.map(({ content, title }) => { | ||
| const guessLinkType = guessLinkTypeBasedOnUrl(content); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import from Linkree feature:
To test go to createPage and click on linktree icon then paste your linkree url