8000 Add zero option to ExtraVectorsFlags to allow blender plugin to set the by Ghostwalker71 · Pull Request #48 · niftools/nifxml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add zero option to ExtraVectorsFlags to allow blender plugin to set the #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2015
Merged

Add zero option to ExtraVectorsFlags to allow blender plugin to set the #48

merged 2 commits into from
Jun 25, 2015

Conversation

Ghostwalker71
Copy link
Contributor

value during export.

8000 @neomonkeus
Copy link
Member

Looks good.
Probably also should increase the version number.
@ttl269 - can you comment/review.

@Ghostwalker71
Copy link
Contributor Author

This change works out of the box with nifskope 1.2.0 alpha 2, no need to version bump

@neomonkeus
Copy link
Member

Updating the version should be general practice.
Features which potentially break compatibility with tools should have either the minor/major component increased depending on the content. This only needs an update to the revision number.

@Ghostwalker71
Copy link
Contributor Author

I had missed your response about incrementing the version number, It's ready to go now.

neomonkeus added a commit that referenced this pull request Jun 25, 2015
@neomonkeus
Merge pull request #48 from Ghostwalker71/fix/extravectorflags
f265c56 
Add zero option to ExtraVectorsFlags to allow blender plugin to set the
@neomonkeus neomonkeus merged commit f265c56 into niftools:develop Jun 25, 2015
@Ghostwalker71 Ghostwalker71 deleted the fix/extravectorflags branch June 25, 2015 16:48
@neomonkeus neomonkeus modified the milestone: Version 0.7 Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@Ghostwalker71 @neomonkeus
0