8000 added billboard mode BS_ROTATE_ABOUT_UP by ttl269 · Pull Request #23 · niftools/nifxml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

added billboard mode BS_ROTATE_ABOUT_UP #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2014
Merged

added billboard mode BS_ROTATE_ABOUT_UP #23

merged 1 commit into from
Apr 24, 2014

Conversation

ttl269
Copy link
Member
@ttl269 ttl269 commented Apr 23, 2014

Added billboard mode called "BS_ROTATE_ABOUT_UP" - it has value 5. It is used in Skyrim and Fallout 3 nifs. Also works in Oblivion.

@ttl269
added billboard mode BS_ROTATE_ABOUT_UP
527ada8 
Added billboard mode called "BS_ROTATE_ABOUT_UP" - it has value 5. It is used in Skyrim and Fallout 3 nifs. Also works in Oblivion.
@neomonkeus
Copy link
Member

Why is the option="9" removed, were there cases where this value was used.
Also why BS_* when the rest have generic names.

@ttl269
Copy link
Member Author
ttl269 commented Apr 24, 2014
  1. Billboard mode is stored in lowest 3 bits. So value 9 is same as value 1. I have found that Oblivion files uses values higher than 7 (found 8, 9, 12) but its "Preview Scene Graph" reports same billboard modes as it would used values 0, 1 or 4. Maybe that bit 3 have some function but it is not reported. Of course we can add duplicates for values 8-13 to nif.xml, so user will see the function of these values.
  2. "BS_" prefix for value 5 is because precisely this name is reported by "Preview Scene Graph" of Oblivion, Fallout and Skyrim. It seems that it is specific Bethesda billboard mode.

@neomonkeus
Copy link
Member

Thanks for the explanation.

neomonkeus added a commit that referenced this pull request Apr 24, 2014
@neomonkeus
Merge pull request #23 from ttl269/feature/NiBillboardNode-update
943f6c9 
added billboard mode BS_ROTATE_ABOUT_UP
@neomonkeus neomonkeus merged commit 943f6c9 into niftools:develop Apr 24, 2014
@ttl269 ttl269 deleted the feature/NiBillboardNode-update branch December 6, 2014 16:18
@neomonkeus neomonkeus modified the milestone: Version 0.7 Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@ttl269 @neomonkeus
0