8000 Fix/skyrim material removal by ttl269 · Pull Request #21 · niftools/nifxml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix/skyrim material removal #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2014
Merged

Fix/skyrim material removal #21

merged 2 commits into from
Mar 31, 2014

Conversation

ttl269
Copy link
Member
@ttl269 ttl269 commented Mar 13, 2014

Replaced "SkyrimMaterial" by "Unknown Int" in NiGeometryData (how it got there?) and bhkCompressedMeshShape as both seems not be havok material definitions.
@neomonkeus @skyfox69 @jonwd7 @throttlekitty @nexustheru @amorilia

@neomonkeus
Copy link
Member
8000 neomonkeus commented Mar 13, 2014

Don't forget @Ghostwalker71

@hexabits hexabits mentioned this pull request Mar 13, 2014
Closed
3 tasks
@Ghostwalker71
Copy link
Contributor

Both of those pointed to the havok material lists created specifically for skyrim and while I am glad to be rid of the game specific lists, you will need to merge the skyrimhavok list with the havok list and set the user version as condition on which value to apply. would really like to see as much of the game specific blocks removed as possible and use the version, user version and user version 2 values to set the conditions.

@hexabits
Copy link
Member

@Ghostwalker71 but the enums could actually differ at the same indices between games. They currently don't however. Oblivion materials are just 0-31.

The converse of that is the same materials themselves are at different indices. HAV_MAT_STONE is 0 in previous games. For Skyrim, HAV_MAT_STONE is 3741512247.

For the collision layers, they differ at the same indices and cannot be merged.

@Ghostwalker71
Copy link
Contributor

can it not be set to read/write as 0 for version <= 20.2.0.7 user version < 12 and read/write 3741512247 for version == 20.2.0.7 user version == 12?
Or am I completely misunderstanding the xml still

@skyfox69
Copy link
Contributor

Well, about NiGeometryData: We both put it there, ttl269 ;-) Have a look here: http://niftools.sourceforge.net/forum/viewtopic.php?f=10&t=4191

@ttl269
Copy link
Member Author
ttl269 commented Mar 14, 2014

@jonwd7 you are right. In the bhkMoppBvTreeShape next 4 bytes after Ref are not havok material definition and should be also defined as Unknown unsigned int.
@Ghostwalker71 @jonwd7 Also havok materials can't be merged. They also differ at same indices. It is case of Oblivion and Fallout3 materials, for example value 14 is Snow in Oblivion but Bottlecap in Fallout3. And in nif.xml there can't be defined option with same value multiple times in same enum. Additionaly I think that having game specific enum lists is more effective - when enum is used somewhere, xml parser selects enum (list of options) only by one condition instead of having one enum filled with large list of conditioned options.
@skyfox69 Oh, you are right. I forgot it :) So it is a problem, because that value behaves as havok material only in case that NiGeometryData is linked from havok specific block, for example bhkNiTriStripsShape.

ttl269 added 2 commits March 22, 2014 18:49
@ttl269 @neomonkeus
removal of SkyrimMaterial
95c475b 
Replaced "SkyrimMaterial" by "Unknown Int" in NiGeometryData (how it got there?) and bhkCompressedMeshShape as both seems not be havok material definitions.
@ttl269 @neomonkeus
material remove from bhkMoppBvTreeShape
6236ea8 
Removed material definition and replaced by Unknown Int.
neomonkeus added a commit that referenced this pull request Mar 31, 2014
@neomonkeus
Merge pull request #21 from ttl269/fix/SkyrimMaterial-removal
5579290 
Fix/skyrim material removal
@neomonkeus neomonkeus merged commit 5579290 into niftools:develop Mar 31, 2014
@neomonkeus neomonkeus deleted the fix/SkyrimMaterial-removal branch March 31, 2014 21:42
@neomonkeus neomonkeus modified the milestone: Version 0.7 Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.7
Development

Successfully merging this pull request may close these issues.
5 participants
@ttl269 @neomonkeus @Ghostwalker71 @hexabits @skyfox69
0