8000 fix: check prev & next date including month and year by adhrinae · Pull Request #1236 · nhn/tui.calendar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: check prev & next date including month and year #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2022
Merged

fix: check prev & next date including month and year #1236

merged 1 commit into from
Aug 3, 2022

Conversation

adhrinae
Copy link
Contributor
@adhrinae adhrinae commented Aug 1, 2022

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Fixed a weird event move behavior when the prev date or the next date has a different month and year.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@adhrinae adhrinae mentioned this pull request Aug 1, 2022
Merged
6 tasks
lja1018
lja1018 approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor
@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

@adhrinae adhrinae merged commit 373b1e9 into main Aug 3, 2022
@adhrinae adhrinae deleted the fix/event-move-in-date-transition branch August 3, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heenakwag heenakwag heenakwag approved these changes

@lja1018 lja1018 lja1018 approved these changes

@jwlee1108 jwlee1108 Awaiting requested review from jwlee1108

@jajugoguma jajugoguma Awaiting requested review from jajugoguma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adhrinae @heenakwag @lja1018
0