8000 fix(www): remove duplicate scrollbar by Mattewn99 · Pull Request #4829 · ngrx/platform · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(www): remove duplicate scrollbar #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

Mattewn99
Copy link
Contributor

Closes #4828

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

When viewing API documentation pages, code blocks (especially those with long function signatures) show a double horizontal scrollbar. This occurs due to nested scrollable containers within the code rendering components.
On macOS, when system scrollbar visibility is set to "When scrolling", the inner scrollbar becomes inaccessible — trackpad scrolling doesn't work inside the code blocks, effectively making the content unreadable in some cases.

Closes #4828

What is the new behavior?

Code blocks now render with a single horizontal scrollbar. More importantly, scrolling now works properly on macOS trackpads when the system is set to show scrollbars only while scrolling.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Copy link
netlify bot commented Jun 13, 2025

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 248b514
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/684bdf2129d9f200084b3843

Copy link
netlify bot commented Jun 13, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 248b514
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/684bdf21dd84520008ba60a4
😎 Deploy Preview https://deploy-preview-4829--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yousafravian
Copy link

Cool, I was also looking into it and wasn't even able to set up the docs analogjs app locally. 😵‍💫
Yarn kept complaining

Copy link
Member
@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mattewn99 !

@timdeschryver
Copy link
Member

Cool, I was also looking into it and wasn't even able to set up the docs analogjs app locally. 😵‍💫 Yarn kept complaining

We've migrated to pnpm, which might be the cause of this problem.

@markostanimirovic
Copy link
Member

Thanks @Mattewn99!

@markostanimirovic markostanimirovic merged commit f0f1f2a into ngrx:main Jun 16, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Docs] Double scroll bar in API samples
4 participants
0