nf-test for local execute_clustering subworkflow #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing_tool param as input, added nf-test config files
maxibor
requested changes
Mar 25, 2025
| @@ -18,7 +19,7 @@ workflow EXECUTE_CLUSTERING { | |||
| MMSEQS_CREATEDB( sequences ) | |||
| ch_versions = ch_versions.mix( MMSEQS_CREATEDB.out.versions ) | |||
|
|
|||
| if (params.clustering_tool == 'cluster') { | |||
| if (clustering_tool == 'cluster') { | |||
| cluster_res = MMSEQS_CLUSTER( MMSEQS_CREATEDB.out.db ) | |||
| ch_versions = ch_versions.mix( MMSEQS_CLUSTER.out.versions ) | |||
| } else { // fallback: linclust | |||
There was a problem hiding this comment.
In the test you test if clustering_tool is cluster or linclust, but here only if it's different from cluster.
Is there a reason for that ?
Could you harmonize it ?
Otherwise, LGTM :)
There was a problem hiding this comment.
Since there are currently only two choices ['linclust', 'cluster'], the else condition captures the linclust option ;)
There was a problem hiding this comment.
OK, I just saw the keyword 'hamronize'. Explicitly stated linclust as the alternate option. Anything else is caught and thrown as error at the json schema level.
…aught at schema level due to enum
maxibor
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).