8000 Release 1.2.1 by apeltzer · Pull Request #59 · nf-core/nanostring · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release 1.2.1 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Jan 18, 2024
Merged

Release 1.2.1 #59

merged 36 commits into from
Jan 18, 2024

Conversation

apeltzer
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/nanostring branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

nf-core-bot and others added 30 commits September 25, 2023 15:16
@nf-core-bot
Template update for nf-core/tools version 2.10
9df8608
@nf-core-bot
Template update for nf-core/tools version 2.11
70f9a13
@apeltzer
Add paper
d870195
@apeltzer
Merge branch 'add-paper' into nf-core-template-merge-2.11
a33f9e0
@apeltzer
No subworkflows
4e335f2
@apeltzer
Cleaner modules.json
2aa3fe6
@apeltzer
Merge pull request #54 from nf-core/nf-core-template-merge-2.11
9457ebf 
Important! Template update for nf-core/tools v2.11
@apeltzer
Fix last bits
18436f9
@apeltzer
Minor addition
8f5d337
@apeltzer
Merge pull request #55 from nf-core/add-paper
e7c564c 
Add paper & Update to template 2.11.1
@apeltzer
Fixes Add pipeline map to docs #52
a05f7b9
@apeltzer
Merge pull request #56 from nf-core/add-tubemap
c6cf2f3
@apeltzer
Cleaning up a bit
5c07755
@apeltzer
Fix ggplot2 imports
518f132
@apeltzer
Attempt at fixing things
5a23113
@apeltzer
Adding in readr
4517141
@apeltzer
A bit more cleaning
a61dba9
@apeltzer
Add column to rownames
2e0b213
@apeltzer
Adding in tibble
fcac0d8
@apeltzer
improve version logging substantially
7d0c688
@apeltzer
Updated mulled container with tidyr
1f210d8
@apeltzer
Hopefully fixing things
e81331c
@apeltzer
Run matrixstats
b9191ae
@apeltzer
Update compute_gene_scores.nf
28f8552 
Adjust container with matrixstats one
@nf-core-bot
[automated] Fix linting with Prettier
6980075
@apeltzer
Merge branch 'granularize-containers' of https://github.com/nf-core/n…
78dcf12 
…anostring into granularize-containers
@apeltzer
Bump 1.2.1 for new release
055814f
@apeltzer @christopher-mohr
CHANGELOG.md aktualisieren
9688cdc 
Co-authored-by: Christopher Mohr <contact.cmohr@gmail.com>
@nf-core-bot
[automated] Fix linting with Prettier
711ceef
@apeltzer
[skip ci] adjust heatmap title
a0fe70e
@github-actions GitHub Actions
Copy link
github-actions bot commented Jan 17, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 3ed0a4b

+| ✅ 162 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.2.1
  • pipeline_todos - TODO string in WorkflowNanostring.groovy: Optionally add in-text citation tools to this list.

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-18 08:14:36

apeltzer
apeltzer commented Jan 17, 2024
View reviewed changes
christopher-mohr
christopher-mohr requested changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator
@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple of minor things

6DAF
@apeltzer @christopher-mohr
Apply suggestions from code review
e451eb5 
Co-authored-by: Christopher Mohr <contact.cmohr@gmail.com>
apeltzer
apeltzer commented Jan 18, 2024
View reviewed changes
@apeltzer
Copy link
Member Author

@nf-core-bot pretty please fix linting

@apeltzer
Copy link
Member Author

@nf-core-bot fix linting pretty please

@apeltzer apeltzer merged commit b79564a into master Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@christopher-mohr christopher-mohr christopher-mohr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apeltzer @maxulysse @christopher-mohr @nf-core-bot
0