8000 Migrate `cnvpytor/partition` to nf-test by LouisLeNezet · Pull Request #8546 · nf-core/modules · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Migrate cnvpytor/partition to nf-test #8546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Migrate cnvpytor/partition to nf-test #8546

wants to merge 3 commits into from
+157 −58

Conversation

LouisLeNezet
Copy link
Contributor

PR checklist

Closes #7552

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile 8000 singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@LouisLeNezet LouisLeNezet self-assigned this May 24, 2025
@LouisLeNezet LouisLeNezet requested a review from SPPearce May 25, 2025 10:11
SPPearce
SPPearce approved these changes May 25, 2025
View reviewed changes
Copy link
Contributor
@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to descr 96C5 ibe this comment to others. Learn more.

Looks good to me.
I had a feeling that we'd struggled to get this module to actually output anything, but it is a non zero output file

@github-project-automation github-project-automation bot moved this from Todo to In Progress in nf-test Migration May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPPearce SPPearce SPPearce approved these changes

Assignees

@LouisLeNezet LouisLeNezet

Labels
nf-test
Projects
nf-test Migration
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nf-test migration: cnvpytor/partition
2 participants
@LouisLeNezet @SPPearce
0