8000 Added fa-lint by GallVp · Pull Request #8488 · nf-core/modules · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added fa-lint #8488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your accoun 8000 t

Jump to bottom
Merged
merged 3 commits into from
May 19, 2025
Merged

Added fa-lint #8488

merged 3 commits into from
May 19, 2025

Conversation

GallVp
Copy link
Member
@GallVp GallVp commented May 16, 2025

PR checklist

Closes #8479

  • Added fa-lint
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

dialvarezs
dialvarezs approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor
@dialvarezs dialvarezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GallVp GallVp added this pull request to the merge queue May 19, 2025
Merged via the queue into nf-core:master with commit 465f81d May 19, 2025
@GallVp GallVp deleted the add/falint branch May 19, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dialvarezs dialvarezs dialvarezs approved these changes

Assignees
No one assigned
Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new module: FALINT
2 participants
@GallVp @dialvarezs
0