feat: Hash user IDs by default for improved privacy #1335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
- Enabled by default, but optional
- Improves privacy of guests as their user id does not automatically leak their email address (e.g. avatars in chats and more)
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
come-nc
reviewed
May 5, 2025
| @@ -85,14 +81,20 @@ protected function execute(InputInterface $input, OutputInterface $output) { | |||
| return 1; | |||
| } | |||
|
|
|||
| $email = $input->getArgument('email'); | |||
| if ($this->config->useHashedEmailAsUserID()) { | |||
| $email = strtolower($email); | |||
There was a problem hiding this comment.
Should that be mb_strtolower like in UserBackend?
There was a problem hiding this comment.
mb is not allowed in user ids nor in emails, so not sure it's required?
Comment on lines
+279
to
+282
| $users[(string)$row['uid']] = [ | ||
| 'email' => (string)$row['email'], | ||
| 'displayname' => (string)$row['displayname'], | ||
| ]; |
There was a problem hiding this comment.
nit: a generator may make sense here: Do all guests fit in memory?
There was a problem hiding this comment.
getDisplayNames() above is basically doing the same thing. Just had to do an array as value so we can have email + displayname
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews
2CE9
.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.