Enable TLS connection for Redis #2334
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Vest <ziris85@live.com>
|
Hello, I was here to add this feature, but you've done it. Seems not complicated if cert,key and ca are given with base64 string. |
|
I will probably add support for mTLS with Mariadb to ... |
|
Needs documentation in REDME |
Signed-off-by: Ziris85 <ziris85@live.com>
|
Good point @J0WI , thanks! Just updated README for that. |
|
This merge is of public interest. Why hasn't it been accepted yet? |
|
Is this waiting on me for anything? I'll be happy to fix/update whatever else is necessary to get this finished 🙂 |
|
It needs rebase. Please only commit the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This is a hopefully simple PR to allow users to configure Redis to connect to a TLS-enabled Redis endpoint. It proposes a new environment variable
REDIS_PROTOCOLthat can be passed to the container, and replaces all areas (that I found) wheretcp://was either hard-coded or the assumed (omitted) default. All adjustments will continue to usetcpas the default if the env var isn't passed, so this shouldn't impact existing installations.I don't do PR's very frequently so apologies if I missed something here, but I'm interested in thoughts/feedback!
Thank you!