8000 Fix sound after mic permission was granted by mahibi · Pull Request #4800 · nextcloud/talk-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix sound after mic permission was granted #4800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

Fix sound after mic permission was granted #4800

merged 1 commit into from
Mar 21, 2025

Conversation

mahibi
Copy link
Collaborator
@mahibi mahibi commented Mar 14, 2025 •
edited
Loading

fix #4797

This PR will make sure necessary permissions are granted before starting the call at all

STR:

  • have no permissions granted for android app
  • call from web to android
  • grant permissions while joining the call

Without this PR:
Audio is not sent from android to web

With this PR:
Audio is sent to web

How to test:

  • please test the STR described above
  • please test all different call scenarios that come to your mind in terms of permissions

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi self-assigned this Mar 14, 2025
@mahibi mahibi force-pushed the bugfix/4797/noSoundFromAndroidAfterPermissionGranted branch from 3bc6f60 to abf4e8a Compare March 14, 2025 13:57
@mahibi mahibi added the 3. to review Waiting for reviews label Mar 14, 2025
@mahibi mahibi added this to the 21.1.0 milestone Mar 14, 2025
@mahibi mahibi marked this pull request as ready for review March 14, 2025 14:06
@mahibi mahibi requested a review from danxuliu March 14, 2025 14:07
@mahibi
Copy link
Collaborator Author
mahibi commented Mar 20, 2025

@sowjanyakch @rapterjet2004 can you review this one? Would like to have it merged before i begin with "adding participants to 1:1 calls" (~next monday)

@sowjanyakch
Copy link
Contributor

@mahibi - Could you please update the branch with the latest Gradle version? I updated Android Studio and Gradle, and now I get errors when trying to build this PR. Tried to rebase on master and I am getting merge conflicts. It will be easier for me to review if the branch is up to date.

@mahibi
fix no sound after mic permission granted
fbad489 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the bugfix/4797/noSoundFromAndroidAfterPermissionGranted branch from abf4e8a to fbad489 Compare March 21, 2025 10:42
@mahibi
Copy link
Collaborator Author
mahibi commented Mar 21, 2025

@mahibi - Could you please update the branch with the latest Gradle version? I updated Android Studio and Gradle, and now I get errors when trying to build this PR. Tried to rebase on master and I am getting merge conflicts. It will be easier for me to review if the branch is up to date.

sure, done (had no conflicts though)

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9897
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222118
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310206

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4800-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@sowjanyakch sowjanyakch merged commit fb31bcc into master Mar 21, 2025
17 checks passed
@sowjanyakch sowjanyakch deleted the bugfix/4797/noSoundFromAndroidAfterPermissionGranted branch March 21, 2025 15:15
@poulpor
Copy link
poulpor commented Apr 2, 2025

I can't thank @binsentsu and Talk devs enough for fixing this crippling bug, I honestly lost faith at some point and switched to another solution but would gladly return to Talk because it was working really good on my device before v17.1, 18 months ago.

Will there be a v21.1.0 alpha release (currently running v21.1.0 Alpha 12) to test this very long awaited fix, pwetty please?

@mahibi
Copy link
Collaborator Author
mahibi commented Apr 2, 2025

/backport to stable-21.0

@mahibi
Copy link
Collaborator Author
mahibi commented Apr 2, 2025 •
edited
Loading

I can't thank @binsentsu and Talk devs enough for fixing this crippling bug, I honestly lost faith at some point and switched to another solution but would gladly return to Talk because it was working really good on my device before v17.1, 18 months ago.

Will there be a v21.1.0 alpha release (currently running v21.1.0 Alpha 12) to test this very long awaited fix, pwetty please?

thank for the feedback. I will make sure it's included in the next hotfix release

@backportbot backportbot bot mentioned this pull request Apr 2, 2025
Merged
@poulpor
Copy link
poulpor commented Apr 2, 2025 •
edited
Loading

I can't thank @binsentsu and Talk devs enough for fixing this crippling bug, I honestly lost faith at some point and switched to another solution but would gladly return to Talk because it was working really good on my device before v17.1, 18 months ago.
Will there be a v21.1.0 alpha release (currently running v21.1.0 Alpha 12) to test this very long awaited fix, pwetty please?

thank for the feedback. I will make sure it's included in the next hotfix release

Please excuse me to bother you again, but does 4833-talk.apk contains the actual fix for this microphone permission bug? If so, I've just installed it on my venerable Samsung Note 8 (Android 9) test unit and it still doesn't work, then I rolled back to 17.0.2 and it's fine again... If I can help to debug more, please don't hesitate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sowjanyakch sowjanyakch sowjanyakch approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@mahibi mahibi

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
21.1.0
Development

Successfully merging this pull request may close these issues.

No sound from android in a call after granting microphone permission
3 participants
@mahibi @sowjanyakch @poulpor
0