8000 Added offline check in handleHttpExceptions in ConversationsListActivity by rapterjet2004 · Pull Request #4702 · nextcloud/talk-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added offline check in handleHttpExceptions in ConversationsListActivity #4702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

Added offline check in handleHttpExceptions in ConversationsListActivity #4702

merged 1 commit into from
Feb 17, 2025

Conversation

rapterjet2004
Copy link
Contributor

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 added the 3. to review Waiting for reviews label Feb 7, 2025
@rapterjet2004 rapterjet2004 requested a review from mahibi February 7, 2025 17:03
@rapterjet2004 rapterjet2004 self-assigned this Feb 7, 2025
@rapterjet2004 @mahibi
Added offline check in handleHttpExceptions in ConversationsListActivity
9f9fd1a 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@mahibi mahibi enabled auto-merge February 17, 2025 10:47
@mahibi
Copy link
Collaborator
mahibi commented Feb 17, 2025

/backport to stable-21.0

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104104
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4702-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit bd720b8 into master Feb 17, 2025
19 checks passed
@mahibi mahibi deleted the pr-4674-follow-up branch February 17, 2025 11:03
@backportbot backportbot bot mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

Assignees

@rapterjet2004 rapterjet2004

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rapterjet2004 @mahibi
0