8000 remove duplicated dependencies by mahibi · Pull Request #4664 · nextcloud/talk-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove duplicated dependencies 8000 #4664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2025
Merged

remove duplicated dependencies #4664

merged 1 commit into from
Jan 29, 2025

Conversation

mahibi
Copy link
Collaborator
@mahibi mahibi commented Jan 28, 2025

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi
remove duplicated dependencies
bf97d93 
+ minor refactoring

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi added the 3. to review Waiting for reviews label Jan 28, 2025
@mahibi mahibi added this to the 21.1.0 milestone Jan 28, 2025
@mahibi mahibi self-assigned this Jan 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4664-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104104
Errors3636

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

@rapterjet2004 rapterjet2004 merged commit 9aa9918 into master Jan 29, 2025
19 checks passed
8000
@rapterjet2004 rapterjet2004 deleted the fixDuplicatedDependencies branch January 29, 2025 00:04
@mahibi
Copy link
Collaborator Author
mahibi commented Jan 29, 2025

/backport to stable-21.0

@backportbot backportbot bot mentioned this pull request Jan 29, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rapterjet2004 rapterjet2004 rapterjet2004 approved these changes

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

Assignees

@mahibi mahibi

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
21.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mahibi @rapterjet2004
0