8000 enable to select authentication cert in server selection screen by mahibi · Pull Request #4634 · nextcloud/talk-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

enable to select authentication cert in server selection screen #4634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2025
Merged

enable to select authentication cert in server selection screen #4634

merged 1 commit into from
Jan 20, 2025

Conversation

mahibi
Copy link
Collaborator
@mahibi mahibi commented Jan 20, 2025

resolve #3907
resolve #4421

This will enable the "Select authentication certificate" option on server selection screen.

I plan to have this enabled for v21.0.0 RC1 and collect some feedback before deciding to include it in v21.0.0 final.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi
enable to select authentication cert in server selection screen
28ffb7f 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi added the 3. to review Waiting for reviews label Jan 20, 2025
@mahibi mahibi added this to the 21.0.0 milestone Jan 20, 2025
@mahibi mahibi requested a review from rapterjet2004 January 20, 2025 09:46
@mahibi mahibi self-assigned this Jan 20, 2025
@mahibi mahibi mentioned this pull request Jan 20, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4634-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104104
Errors3636

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

@mahibi mahibi requested a review from nickvergessen January 20, 2025 10:55
@mahibi mahibi enabled auto-merge January 20, 2025 10:55
@mahibi mahibi merged commit 3522ab7 into master Jan 20, 2025
18 checks passed
@mahibi mahibi deleted the enableCertSelection branch January 20, 2025 10:55
@migulen
Copy link
migulen commented Jan 21, 2025

@mahibi I can confirm that with this PR.... IT WORKS!!! But....

only if you "delete the account" and I think, i'm not sure, if you clean the data cache/aplication.

Then you login the account selecting the "client certificate", and all work like a charm.

So the problem is that, already configured accounts can not make the client certificate be ACTIVE only selecting it on "Configure your client certificate" on the configuration profile inside the app. <--- that way will be nice one for all the people with already configured accounts.

Thanks for all @mahibi .

@pboguslawski pboguslawski mentioned this pull request Jan 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@mahibi mahibi

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
21.0.0
Development

Successfully merging this pull request may close these issues.

HTTP 400 when logging in to server that is secured with mTLS Support for mTLS
3 participants
@mahibi @migulen @nickvergessen
0