8000 show message send button when there is text in input message field by sowjanyakch · Pull Request #4551 · nextcloud/talk-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

show message send button when there is text in input message field #4551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2025
Merged

show message send button when there is text in input message field #4551

merged 1 commit into from
Jan 8, 2025

Conversation

sowjanyakch
Copy link
Contributor

Resolve #4488

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch marked this pull request as ready for review December 16, 2024 16:23
@sowjanyakch sowjanyakch self-assigned this Dec 16, 2024
@sowjanyakch sowjanyakch changed the title show send button when there is text in input message field show message send button when there is text in input message field Dec 16, 2024
@sowjanyakch @mahibi
show send button when there is text in input message field
d36f3c9 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@mahibi mahibi enabled auto-merge January 8, 2025 15:45
@mahibi
Copy link
Collaborator
mahibi commented Jan 8, 2025

/backport to stable-20.1

@mahibi mahibi added this to the 21.0.0 milestone Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 8, 2025

Codacy

Lint

TypemasterPR
Warnings158158
Errors7171

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 8, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4551-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 585f66d into master Jan 8, 2025
18 checks passed
@mahibi mahibi deleted the show_send_button branch January 8, 2025 15:58
@backportbot backportbot bot mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels
None yet
Projects
None yet
Milestone
21.0.0
Development

Successfully merging this pull request may close these issues.

Send button does not appear or link is not automatically sent when sharing links with talk users from other apps on Android
2 participants
@sowjanyakch @mahibi
0